linux-kernel - Re: [PATCH] Coding Style: Format arch/arm/boot/dts/xilinx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f514d490-75d8-408e-99ba-ee44916395fc@amd.com>
Date: Wed, 7 Jan 2026 08:49:21 +0100
From: Michal Simek <michal.simek@....com>
To: kylebonnici <kylebonnici@...ton.me>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>,
 Peter Korsgaard <peter@...sgaard.com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 Kyle Bonnici <kylebonnici@...mail.com>
Subject: Re: [PATCH] Coding Style: Format arch/arm/boot/dts/xilinx

Hi,

On 1/6/26 21:28, kylebonnici wrote:
> Hi,
> 

first of all please don't do top posting.

> Thanks for the feedback.
> 
> with regard to subject I am not sure in what subsystem file formatting would go (especially if we run it on even more files and more systems are modified) Your guidance would be appreciated.

arm: xilinx:

or for 64 bit version

arm64: xilinx:

> 
> With regard to improving the line wrapping, can you share some examples so that I can start looking on improving this?


run it over zynqmp.dtsi file
And focus on pcie node

  @@ -958,8 +979,10 @@ pcie: pcie@...e0000 {
                                <0x0 0xfd480000 0x0 0x1000>,
                                <0x80 0x00000000 0x0 0x10000000>;
                          reg-names = "breg", "pcireg", "cfg";
  -                       ranges = <0x02000000 0x00000000 0xe0000000 0x00000000 
0xe0000000 0x00000000 0x10000000>,/* non-prefetchable memory */
  -                                <0x43000000 0x00000006 0x00000000 0x00000006 
0x00000000 0x00000002 0x00000000>;/* prefetchable memory */
  +                       ranges = <0x02000000 0x00000000 0xe0000000 0x00000000 
0xe0000000 0x00000000
  +                                 0x10000000>,/* non-prefetchable memory */
  +                                <0x43000000 0x00000006 0x00000000 0x00000006 
0x00000000 0x00000002
  +                                 0x00000000>;/* prefetchable memory */
                          bus-range = <0x00 0xff>;

1. sometimes commens are using space,tab or nothing. Same style would be useful.
2. last cell on next line looks weird to me. I think you can decode 
address-cells/size-cells for ranges and do indentation base on it.

> 
> To run on more files I will wait for feedback from Rob, Krzysztof and Conor.

yep.

Thanks,
Michal