linux-kernel - Re: [PATCH v3 1/2] dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b724795f-1a76-4cc2-9417-2e4dd7dc7305@kernel.org>
Date: Wed, 7 Jan 2026 09:20:13 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jishnu Prakash <jishnu.prakash@....qualcomm.com>
Cc: Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Fenglin Wu <quic_fenglinw@...cinc.com>, linux-leds@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, aiqun.yu@....qualcomm.com,
 kamal.wadhwa@....qualcomm.com, yijie.yang@....qualcomm.com,
 jingyi.wang@....qualcomm.com
Subject: Re: [PATCH v3 1/2] dt-bindings: leds: leds-qcom-lpg: Add support for
 PMH0101 PWM

On 22/12/2025 14:06, Jishnu Prakash wrote:
> Hi Krzysztof,
> 
> On 12/17/2025 1:45 PM, Krzysztof Kozlowski wrote:
>> On Mon, Dec 15, 2025 at 04:41:04PM +0530, Jishnu Prakash wrote:
>>> Add support for PMH0101 PWM modules which are compatible with the PM8350c
>>> PWM modules.
>>>
>>> Signed-off-by: Jingyi Wang <jingyi.wang@....qualcomm.com>
>>> Signed-off-by: Jishnu Prakash <jishnu.prakash@....qualcomm.com>
>>> ---
>>>  Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>> So how many nvmem entries it has? You need to define it in schema.
>>
> 
> PMH0101 PWM has 2 nvmem entries, the same as PM8350C. But I see that
> PM8550 PWM was earlier added under the "if:then" condition for the number
> of nvmem entries and you made this change which removed that line:

Right, code is fine.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

Best regards,
Krzysztof