[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aV4YA6wFjPD8G9kk@yuanjiey.ap.qualcomm.com>
Date: Wed, 7 Jan 2026 16:23:31 +0800
From: yuanjiey <yuanjie.yang@....qualcomm.com>
To: Sudarshan Shetty <tessolveupstream@...il.com>
Cc: andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 4/5] arm64: dts: qcom: talos: Fix inconsistent USB
PHY node naming
On Tue, Dec 30, 2025 at 06:32:26PM +0530, Sudarshan Shetty wrote:
> The USB PHY nodes has inconsistent labels as 'usb_1_hspy'
> and 'usb_hsphy_2'. This patch renames them to follow
> a consistent naming scheme.
>
> No functional changes, only label renaming.
>
> Signed-off-by: Sudarshan Shetty <tessolveupstream@...il.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/talos.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi
> index 95d26e313622..c7dc507a50b5 100644
> --- a/arch/arm64/boot/dts/qcom/talos.dtsi
> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi
> @@ -4304,7 +4304,7 @@ osm_l3: interconnect@...21000 {
> #interconnect-cells = <1>;
> };
>
> - usb_1_hsphy: phy@...2000 {
> + usb_hsphy_1: phy@...2000 {
Here just modify talos.dtsi, not modify qcs615-ride.dts
we will meet compile error.
Error: arch/arm64/boot/dts/qcom/qcs615-ride.dts:635.1-13 Label or path usb_1_hsphy not found.
Thanks,
Yuanjie
compatible = "qcom,qcs615-qusb2-phy";
> reg = <0x0 0x88e2000 0x0 0x180>;
>
> @@ -4412,7 +4412,7 @@ usb_1_dwc3: usb@...0000 {
> iommus = <&apps_smmu 0x140 0x0>;
> interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
>
> - phys = <&usb_1_hsphy>, <&usb_qmpphy>;
> + phys = <&usb_hsphy_1>, <&usb_qmpphy>;
> phy-names = "usb2-phy", "usb3-phy";
>
> snps,dis-u1-entry-quirk;
> --
> 2.34.1
Powered by blists - more mailing lists