linux-kernel - Re: [PATCH v2 1/4] dt-bindings: i2c: qcom-cci: Document sm6150 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7fc7c14c-a305-422e-8755-22e7c28bcfb3@kernel.org>
Date: Wed, 7 Jan 2026 09:34:39 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wenmeng Liu <wenmeng.liu@....qualcomm.com>
Cc: Loic Poulain <loic.poulain@....qualcomm.com>,
 Robert Foss <rfoss@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Todor Tomov <todor.too@...il.com>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
 linux-i2c@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: i2c: qcom-cci: Document sm6150
 compatible

On 07/01/2026 09:17, Wenmeng Liu wrote:
> 
> 
> On 1/7/2026 4:00 PM, Krzysztof Kozlowski wrote:
>> On Tue, Jan 06, 2026 at 05:39:53PM +0800, Wenmeng Liu wrote:
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            enum:
>>> +              - qcom,sm6150-cci
>>> +    then:
>>> +      properties:
>>> +        clocks:
>>> +          minItems: 3
>>> +          maxItems: 3
>>> +        clock-names:
>>> +          items:
>>> +            - const: soc_ahb
>>
>> Same question as before. I did not see any resolution of this in
>> changelog or commit msg.
>>
> Will update commit msg in next version:
> 
> For this platform, it uses soc_ahb instead of camnoc_axi.

That was not my question from v1. AHB and AXI are both bus clocks,
meaning for this device the same. You again name the clocks how you
called them in clock controller which is wrong. You name here CLOCK
INPUTS. What is the role of this clock FOR THIS DEVICE?

I already asked to pay attention to this difference.

Best regards,
Krzysztof