linux-kernel - Re: [PATCH v2 0/2] thunderbolt: Fix S4 resume incongruities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260107093353.GO2275908@black.igk.intel.com>
Date: Wed, 7 Jan 2026 10:33:53 +0100
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: "Mario Limonciello (AMD)" <superm1@...nel.org>
Cc: "open list:THUNDERBOLT DRIVER" <linux-usb@...r.kernel.org>,
	linux-kernel@...r.kernel.org,
	Andreas Noever <andreas.noever@...il.com>,
	Michael Jamet <michael.jamet@...el.com>,
	Yehezkel Bernat <YehezkelShB@...il.com>
Subject: Re: [PATCH v2 0/2] thunderbolt: Fix S4 resume incongruities

Hi,

On Mon, Jan 05, 2026 at 11:37:47PM -0600, Mario Limonciello (AMD) wrote:
> When a machine is restored from S4 if the firmware CM has created
> tunnels there can be an incongruity of expectation from the kernel
> when compared to booting from S5.  This series addresses those.

I suspect there is no Firmware CM in AMD platforms so this actually means
the BIOS CM, correct?

However, on S4 we actually do reset host router when the "boot kernel" is
started before loading and jumping to the hibernation image. It might be
that this boot kernel tunnel configuration is causing the issues you are
seeing (can you elaborate on those?) but given that it is (typically the
same kernel binary) it should be creating the tunnels the same way.

> 
> v1:
> Link: https://lore.kernel.org/linux-usb/20251023050354.115015-1-superm1@kernel.org/
> 
> Mario Limonciello (AMD) (2):
>   thunderbolt: Move nhi_reset before pmops declaration
>   thunderbolt: Reset NHI during S4 restore_noirq() callback
> 
>  drivers/thunderbolt/nhi.c | 77 ++++++++++++++++++++++-----------------
>  drivers/thunderbolt/tb.c  | 29 ++++++++-------
>  drivers/thunderbolt/tb.h  |  1 +
>  3 files changed, 61 insertions(+), 46 deletions(-)
> 
> -- 
> 2.43.0