[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20260107103655.2d25bcc3@kmaincent-XPS-13-7390>
Date: Wed, 7 Jan 2026 10:36:55 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: Andrew Davis <afd@...com>
Cc: Jyri Sarha <jyri.sarha@....fi>, Tomi Valkeinen
<tomi.valkeinen@...asonboard.com>, Maarten Lankhorst
<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>, Rob Herring <robh@...nel.org>, Krzysztof
Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Russell
King <linux@...linux.org.uk>, "Bartosz Golaszewski" <brgl@...ev.pl>, Tony
Lindgren <tony@...mide.com>, Andrzej Hajda <andrzej.hajda@...el.com>, Neil
Armstrong <neil.armstrong@...aro.org>, "Robert Foss" <rfoss@...nel.org>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman
<jonas@...boo.se>, "Jernej Skrabec" <jernej.skrabec@...il.com>, Markus
Schneider-Pargmann <msp@...libre.com>, Bajjuri Praneeth <praneeth@...com>,
Luca Ceresoli <luca.ceresoli@...tlin.com>, Louis Chauvet
<louis.chauvet@...tlin.com>, Thomas Petazzoni
<thomas.petazzoni@...tlin.com>, Miguel Gazquez
<miguel.gazquez@...tlin.com>, Herve Codina <herve.codina@...tlin.com>,
<dri-devel@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
<linux-omap@...r.kernel.org>
Subject: Re: [PATCH v3 04/22] drm/tilcdc: Add support for DRM bus flags and
simplify panel config
On Tue, 6 Jan 2026 13:30:40 -0600
Andrew Davis <afd@...com> wrote:
> > static int tilcdc_init(const struct drm_driver *ddrv, struct device *dev)
> > {
> > struct drm_device *ddev;
> > struct platform_device *pdev = to_platform_device(dev);
> > struct device_node *node = dev->of_node;
> > + const struct of_device_id *of_id;
> > struct tilcdc_drm_private *priv;
> > u32 bpp = 0;
> > int ret;
> > @@ -209,6 +222,10 @@ static int tilcdc_init(const struct drm_driver *ddrv,
> > struct device *dev) if (IS_ERR(ddev))
> > return PTR_ERR(ddev);
> >
> > + of_id = of_match_node(tilcdc_of_match, node);
>
> You should be able to use `device_get_match_data()` here, then you would
> also be able to keep the tilcdc_of_match table down were it was before.
Indeed. Didn't know this helper.
Thanks you!
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
Powered by blists - more mailing lists