linux-kernel - Re: [PATCH] arch/sparc: fix unused vaiable warning error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <753883ca-5c30-4169-9548-cac76a2de00a@gmail.com>
Date: Wed, 7 Jan 2026 17:36:34 +0800
From: Alex Shi <seakeel@...il.com>
To: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
 alexs@...nel.org, "David S. Miller" <davem@...emloft.net>,
 Andreas Larsson <andreas@...sler.com>,
 "open list:SPARC + UltraSPARC (sparc/sparc64)" <sparclinux@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>
Cc: kernel test robot <lkp@...el.com>, Matthew Wilcox <willy@...radead.org>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 Qi Zheng <zhengqi.arch@...edance.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>, Zi Yan <ziy@...dia.com>,
 Kevin Brodsky <kevin.brodsky@....com>, Mike Rapoport <rppt@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] arch/sparc: fix unused vaiable warning error



On 2026/1/7 16:42, John Paul Adrian Glaubitz wrote:
> Hi Alex,
> 
> On Wed, 2026-01-07 at 14:42 +0800,alexs@...nel.org wrote:
>> From: Alex Shi<alexs@...nel.org>
>>
>>     arch/sparc/mm/init_64.c: In function 'arch_hugetlb_valid_size':
>>     arch/sparc/mm/init_64.c:361:24: warning: variable 'hv_pgsz_idx' set but not used [-Wunused-but-set-variable]
>>       361 |         unsigned short hv_pgsz_idx;
>>           |                        ^~~~~~~~~~~
>>
>> Reported-by: kernel test robot<lkp@...el.com>
>> Signed-off-by: Alex Shi<alexs@...nel.org>
>> Cc:sparclinux@...r.kernel.org
>> Cc: Matthew Wilcox<willy@...radead.org>
>> Cc: Lorenzo Stoakes<lorenzo.stoakes@...cle.com>
>> Cc: Qi Zheng<zhengqi.arch@...edance.com>
>> Cc: Dave Hansen<dave.hansen@...ux.intel.com>
>> Cc: Zi Yan<ziy@...dia.com>
>> Cc: Kevin Brodsky<kevin.brodsky@....com>
>> Cc: Mike Rapoport<rppt@...nel.org>
>> Cc: Andrew Morton<akpm@...ux-foundation.org>
>> Cc: Andreas Larsson<andreas@...sler.com>
>> Cc: David S. Miller<davem@...emloft.net>
>> ---
>>   arch/sparc/mm/init_64.c | 6 ------
>>   1 file changed, 6 deletions(-)
>>
>> diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c
>> index df9f7c444c39..ba19d23d4040 100644
>> --- a/arch/sparc/mm/init_64.c
>> +++ b/arch/sparc/mm/init_64.c
>> @@ -358,30 +358,24 @@ static void __init pud_huge_patch(void)
>>   bool __init arch_hugetlb_valid_size(unsigned long size)
>>   {
>>   	unsigned int hugepage_shift = ilog2(size);
>> -	unsigned short hv_pgsz_idx;
>>   	unsigned int hv_pgsz_mask;
>>   
>>   	switch (hugepage_shift) {
>>   	case HPAGE_16GB_SHIFT:
>>   		hv_pgsz_mask = HV_PGSZ_MASK_16GB;
>> -		hv_pgsz_idx = HV_PGSZ_IDX_16GB;
>>   		pud_huge_patch();
>>   		break;
>>   	case HPAGE_2GB_SHIFT:
>>   		hv_pgsz_mask = HV_PGSZ_MASK_2GB;
>> -		hv_pgsz_idx = HV_PGSZ_IDX_2GB;
>>   		break;
>>   	case HPAGE_256MB_SHIFT:
>>   		hv_pgsz_mask = HV_PGSZ_MASK_256MB;
>> -		hv_pgsz_idx = HV_PGSZ_IDX_256MB;
>>   		break;
>>   	case HPAGE_SHIFT:
>>   		hv_pgsz_mask = HV_PGSZ_MASK_4MB;
>> -		hv_pgsz_idx = HV_PGSZ_IDX_4MB;
>>   		break;
>>   	case HPAGE_64K_SHIFT:
>>   		hv_pgsz_mask = HV_PGSZ_MASK_64K;
>> -		hv_pgsz_idx = HV_PGSZ_IDX_64K;
>>   		break;
>>   	default:
>>   		hv_pgsz_mask = 0;
> Thanks for the patch! Could you fix the typo in the subject?

Thanks  a lot. I will update the subject and resend for v2.

Thanks
Alex

> 
> Thanks,
> Adrian
> 
> -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' 
> Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
>