lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <fde4b6ec-a7d6-40e1-96a6-a2f4b601d583@amd.com>
Date: Wed, 7 Jan 2026 13:47:08 +0100
From: Christian König <christian.koenig@....com>
To: Ding Yihan <dingyihan@...ontech.com>, alexander.deucher@....com
Cc: airlied@...il.com, simona@...ll.ch, amd-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: Fix typos in amdgpu_vm_bo_update comments

On 12/23/25 05:41, Ding Yihan wrote:
> Fix spelling mistakes in the comment block within amdgpu_vm_bo_update().
> Specifically, correct "contians" to "contains" and "WIRTEABLE" to
> "WRITEABLE".
> 
> Additionally, improve the grammar, capitalization, and punctuation of
> the comment for better readability.
> 
> Signed-off-by: Ding Yihan <dingyihan@...ontech.com>

Reviewed-by: Christian König <christian.koenig@....com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index c362d4dfb5bb..502d32728008 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -1352,8 +1352,8 @@ int amdgpu_vm_bo_update(struct amdgpu_device *adev, struct amdgpu_bo_va *bo_va,
>  	list_for_each_entry(mapping, &bo_va->invalids, list) {
>  		uint64_t update_flags = flags;
>  
> -		/* normally,bo_va->flags only contians READABLE and WIRTEABLE bit go here
> -		 * but in case of something, we filter the flags in first place
> +		/* Normally,bo_va->flags only contains READABLE and WRITEABLE bits here.
> +		 * But in case of something, we filter the flags in first place.
>  		 */
>  		if (!(mapping->flags & AMDGPU_VM_PAGE_READABLE))
>  			update_flags &= ~AMDGPU_PTE_READABLE;


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ