linux-kernel - Re: [PATCH] scripts: atomic: check for argument in gen-rust-atomic-helpers.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260108165453.54679b9a@nimda>
Date: Thu, 8 Jan 2026 16:54:53 +0300
From: Onur Özkan <work@...rozkan.dev>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Boqun Feng <boqun.feng@...il.com>, Will Deacon <will@...nel.org>, Peter
 Zijlstra <peterz@...radead.org>, Mark Rutland <mark.rutland@....com>, Gary
 Guo <gary@...yguo.net>, Miguel Ojeda <ojeda@...nel.org>, "Björn Roy Baron" <bjorn3_gh@...tonmail.com>, Benno Lossin
 <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, Trevor Gross
 <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>,
 linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] scripts: atomic: check for argument in
 gen-rust-atomic-helpers.sh

On Thu, 08 Jan 2026 13:08:57 +0000
Alice Ryhl <aliceryhl@...gle.com> wrote:

> Currently, running `scripts/atomic/gen-rust-atomic-helpers.sh` without
> arguments results in a broken header file and grep errors:
> 
>     $ scripts/atomic/gen-rust-atomic-helpers.sh
>     grep: : No such file or directory
>     grep: : No such file or directory
> 
> The user may do this to re-generate the Rust helpers, not realizing
> that they called the wrong script [1]. In this scenario, point the
> user to `scripts/atomic/gen-atomics.sh` instead of failing in a
> cryptic way.
> 
>     $ scripts/atomic/gen-rust-atomic-helpers.sh
>     call scripts/atomic/gen-atomics.sh instead
> 
> Link:
> https://lore.kernel.org/r/CAH5fLghgm2pPdKen2rv6MeSXAYG_j_eCqvM0b=VbTbUM9eswKg@mail.gmail.com
> Signed-off-by: Alice Ryhl <aliceryhl@...gle.com> ---
>  scripts/atomic/gen-rust-atomic-helpers.sh | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/scripts/atomic/gen-rust-atomic-helpers.sh
> b/scripts/atomic/gen-rust-atomic-helpers.sh index
> 45b1e100ed7c63108ee6cb07e48a17668f860d47..1c76f8ae731de9ac069d489469b0383f256b1539
> 100755 --- a/scripts/atomic/gen-rust-atomic-helpers.sh +++
> b/scripts/atomic/gen-rust-atomic-helpers.sh @@ -5,6 +5,11 @@
> ATOMICDIR=$(dirname $0) 
>  . ${ATOMICDIR}/atomic-tbl.sh
>  
> +if [ -z "$1" ]; then
> +	echo "call scripts/atomic/gen-atomics.sh instead" >&2
> +	exit 1
> +fi
> +
>  #gen_proto_order_variant(meta, pfx, name, sfx, order, atomic, int,
> arg...) gen_proto_order_variant()
>  {
> 
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20260108-gen-rust-atomic-helpers-msg-3943461645fb
> 
> Best regards,

Makes sense.

Reviewed-by: Onur Özkan <work@...rozkan.dev>

thanks,
Onur