linux-kernel - Re: [PATCH v11 6/8] crypto: Add RSASSA-PSS support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2745024.1767883164@warthog.procyon.org.uk>
Date: Thu, 08 Jan 2026 14:39:24 +0000
From: David Howells <dhowells@...hat.com>
To: Jarkko Sakkinen <jarkko@...nel.org>
Cc: dhowells@...hat.com, Lukas Wunner <lukas@...ner.de>,
    Ignat Korchagin <ignat@...udflare.com>,
    Herbert Xu <herbert@...dor.apana.org.au>,
    Eric Biggers <ebiggers@...nel.org>,
    Luis Chamberlain <mcgrof@...nel.org>,
    Petr Pavlu <petr.pavlu@...e.com>, Daniel Gomez <da.gomez@...nel.org>,
    Sami Tolvanen <samitolvanen@...gle.com>,
    "Jason A . Donenfeld" <Jason@...c4.com>,
    Ard Biesheuvel <ardb@...nel.org>,
    Stephan Mueller <smueller@...onox.de>, linux-crypto@...r.kernel.org,
    keyrings@...r.kernel.org, linux-modules@...r.kernel.org,
    linux-kernel@...r.kernel.org,
    Tadeusz Struk <tadeusz.struk@...el.com>,
    "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v11 6/8] crypto: Add RSASSA-PSS support

Jarkko Sakkinen <jarkko@...nel.org> wrote:

> > +struct rsassa_pss_ctx {
> > +	struct crypto_akcipher *rsa;
> > +	unsigned int	key_size;
> > +	unsigned int	salt_len;
> > +	char		*pss_hash;
> > +	char		*mgf1_hash;
> > +};
> 
> Just a nit but I would not align these fields as it does not serve any
> purpose here.

It makes them easier to read.

David