linux-kernel - Re: [PATCH v6 1/4] dt-bindings: mfd: Add sony,cronos-smc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAL_JsqLxVpFRPsNy5gRb61HvSohzi=OS3KdacKF7VH_YW3e8_A@mail.gmail.com>
Date: Wed, 7 Jan 2026 18:20:25 -0600
From: Rob Herring <robh+dt@...nel.org>
To: Timothy Pearson <tpearson@...torengineering.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, devicetree <devicetree@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Lee Jones <lee@...nel.org>, 
	Georgy Yakovlev <Georgy.Yakovlev@...y.com>, 
	Shawn Anastasio <sanastasio@...torengineering.com>
Subject: Re: [PATCH v6 1/4] dt-bindings: mfd: Add sony,cronos-smc

On Wed, Jan 7, 2026 at 11:41 AM Timothy Pearson
<tpearson@...torengineering.com> wrote:
>
>
>
> ----- Original Message -----
> > From: "Krzysztof Kozlowski" <krzk@...nel.org>
> > To: "Timothy Pearson" <tpearson@...torengineering.com>
> > Cc: "devicetree" <devicetree@...r.kernel.org>, "linux-kernel" <linux-kernel@...r.kernel.org>, "Rob Herring"
> > <robh+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
> > "Lee Jones" <lee@...nel.org>, "Georgy Yakovlev" <Georgy.Yakovlev@...y.com>, "Shawn Anastasio"
> > <sanastasio@...torengineering.com>
> > Sent: Wednesday, January 7, 2026 11:18:09 AM
> > Subject: Re: [PATCH v6 1/4] dt-bindings: mfd: Add sony,cronos-smc
>
> > On 07/01/2026 18:09, Timothy Pearson wrote:
> >>
> >>
> >> ----- Original Message -----
> >>> From: "Krzysztof Kozlowski" <krzk@...nel.org>
> >>> To: "Timothy Pearson" <tpearson@...torengineering.com>
> >>> Cc: "devicetree" <devicetree@...r.kernel.org>, "linux-kernel"
> >>> <linux-kernel@...r.kernel.org>, "Rob Herring"
> >>> <robh+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>, "Krzysztof
> >>> Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
> >>> "Lee Jones" <lee@...nel.org>, "Georgy Yakovlev" <Georgy.Yakovlev@...y.com>,
> >>> "Shawn Anastasio"
> >>> <sanastasio@...torengineering.com>
> >>> Sent: Wednesday, January 7, 2026 1:25:10 AM
> >>> Subject: Re: [PATCH v6 1/4] dt-bindings: mfd: Add sony,cronos-smc
> >>
> >>> On Tue, Jan 06, 2026 at 06:21:33PM -0600, Timothy Pearson wrote:
> >>>> From: Shawn Anastasio <sanastasio@...torengineering.com>
> >>>>
> >>>> The Sony Cronos Platform Controller is a multi-purpose platform controller
> >>>> that provides both a watchdog timer and an LED controller for the Sony
> >>>> Interactive Entertainment Cronos x86 server platform. As both functions
> >>>> are provided by the same CPLD, a multi-function device is exposed as the
> >>>> parent of both functions.
> >>>>
> >>>> Add a DT binding for this device.
> >>>>
> >>>> Signed-off-by: Shawn Anastasio <sanastasio@...torengineering.com>
> >>>> Signed-off-by: Timothy Pearson <tpearson@...torengineering.com>
> >>>> ---
> >>>>  .../bindings/mfd/sony,cronos-smc.yaml         | 128 ++++++++++++++++++
> >>>
> >>> How this can be a v6 with no changelog at all and still not tested?
> >>>
> >>> What happened with this patchset? Where is it explained?
> >>
> >> Changes have only been to fix issues identified in review and any posted
> >> autotest failures.
> >
> > And where is this explained? Please always provide detailed changelog in
> > the cover letter or individual patch.
> >
> >>
> >> Please note that the tooling to check the DT bindings does NOT appear work
> >> properly, we've wasted a lot of time and effort attempting to get it running
> >> only to find that it's spitting out internal Python errors even for other
> >> drivers that are *already* in the kernel source tree.  This obviously creates a
> >> situation where it's difficult to pre-check the patch set for compliance; if
> >> you want to see this first hand, spin up a Debian Sid VM (which has a very
> >> recent version of the DT tooling from late 2025) and try to check any of the
> >> in-tree MFD drivers using the documented methods.
> >
> > I am using DT schema on multiple distros, including Debian but not Sid
> > but Trixie
> > (https://krzk.eu/#/builders/91/builds/116/steps/13/logs/stdio). Works
> > without problem...
>
> Good to know.  There is next to no documentation on the required software versions to make this work, which complicates
>
> > On regular Debian based distro this is just few commands - pix install
> > and them make dt_binding_check - so I am surprised you spent a lot of
> > time on setting this up.
> >
> > What is the problem exactly?
>
> Good to know.  There is next to no documentation on the required software
> versions to make this work, which complicates setup.

$latest

It's as simple as that. There is some checking of a minimum version,
but maybe we need to bump it more aggressively. I haven't because
older versions might work.

>  Bookworm's DT package was
> too old when it was tried pre-Trixie release, and at the time Sid didn't work
> either for some other reason.  The assumption was that the kernel needed a very
> recent version of the DT tooling, so Sid was tried again this year.  Will try
> Trixie before the next patch update.

Don't use the distro version. There's no one checking that it works.

One problem here (and for distro packaging) has been json-schema pkg
breaking us. So we were stuck on <4.18 for a long time and now require
>=4.18.

Rob