linux-kernel - Re: [PATCH v5 02/11] ACPI: CPPC: Clean up cppc_perf_caps and cppc_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38b4cd89-dcd8-4384-991c-8c364a13e87d@arm.com>
Date: Thu, 8 Jan 2026 14:43:16 +0100
From: Pierre Gondois <pierre.gondois@....com>
To: Sumit Gupta <sumitg@...dia.com>, rafael@...nel.org,
 viresh.kumar@...aro.org, lenb@...nel.org, robert.moore@...el.com,
 corbet@....net, zhenglifeng1@...wei.com, rdunlap@...radead.org,
 ray.huang@....com, gautham.shenoy@....com, mario.limonciello@....com,
 perry.yuan@....com, ionela.voinescu@....com, zhanjie9@...ilicon.com,
 linux-pm@...r.kernel.org, linux-acpi@...r.kernel.org,
 linux-doc@...r.kernel.org, acpica-devel@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Cc: linux-tegra@...r.kernel.org, treding@...dia.com, jonathanh@...dia.com,
 vsethi@...dia.com, ksitaraman@...dia.com, sanjayc@...dia.com,
 nhartman@...dia.com, bbasu@...dia.com
Subject: Re: [PATCH v5 02/11] ACPI: CPPC: Clean up cppc_perf_caps and
 cppc_perf_ctrls structs


On 12/23/25 13:12, Sumit Gupta wrote:
> - Remove redundant energy_perf field from 'struct cppc_perf_caps' as
>    the same is available in 'struct cppc_perf_ctrls' which is used.
> - Move the 'auto_sel' field from 'struct cppc_perf_caps' to
>    'struct cppc_perf_ctrls' as it represents a control register.

I think your SoB is missing, otherwise:

Reviewed-by: Pierre Gondois <pierre.gondois@....com>

> ---
>   include/acpi/cppc_acpi.h | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/acpi/cppc_acpi.h b/include/acpi/cppc_acpi.h
> index 13fa81504844..a090b010f5f1 100644
> --- a/include/acpi/cppc_acpi.h
> +++ b/include/acpi/cppc_acpi.h
> @@ -119,8 +119,6 @@ struct cppc_perf_caps {
>   	u32 lowest_nonlinear_perf;
>   	u32 lowest_freq;
>   	u32 nominal_freq;
> -	u32 energy_perf;
> -	bool auto_sel;
>   };
>   
>   struct cppc_perf_ctrls {
> @@ -128,6 +126,7 @@ struct cppc_perf_ctrls {
>   	u32 min_perf;
>   	u32 desired_perf;
>   	u32 energy_perf;
> +	bool auto_sel;
>   };
>   
>   struct cppc_perf_fb_ctrs {