linux-kernel - Re: [PATCH] wifi: mwifiex: Fix a loop in mwifiex_update_ampdu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9085a572f5fee0a14059c023c3240aa4d96afc08.camel@sipsolutions.net>
Date: Thu, 08 Jan 2026 21:58:46 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Dan Carpenter <dan.carpenter@...aro.org>, Chunfan Chen
 <jeffc@...vell.com>
Cc: Brian Norris <briannorris@...omium.org>, Francesco Dolcini
	 <francesco@...cini.it>, Kalle Valo <kvalo@...nel.org>, Amitkumar Karwar
	 <akarwar@...vell.com>, Cathy Luo <cluo@...vell.com>, 
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] wifi: mwifiex: Fix a loop in
 mwifiex_update_ampdu_rxwinsize()

On Thu, 2026-01-08 at 23:00 +0300, Dan Carpenter wrote:
> The "i" iterator variable is used to count two different things but

nice catch

> unfortunately we can't store two different numbers in the same variable.

:-)

> This was found via static analysis so I'm not positive on the impact
> of this bug.

I think it basically means anything other than the first interface
(using adapter->priv[i] with i>0) will not be updated correctly for A-
MPDU buffer usage (?) if you use more than two interfaces. Given that
most people probably only use a single interface, I suppose the impact
would be rather low.

johannes