linux-kernel - Re: [PATCH v5] panic: add panic_force_cpu= parameter to redirect panic to a specific CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260108160058.07c32194@gandalf.local.home>
Date: Thu, 8 Jan 2026 16:00:58 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Pnina Feder <pnina.feder@...ileye.com>
Cc: akpm@...ux-foundation.org, pmladek@...e.com, bhe@...hat.com,
 linux-kernel@...r.kernel.org, lkp@...el.com, mgorman@...e.de,
 mingo@...hat.com, peterz@...radead.org, senozhatsky@...omium.org,
 tglx@...utronix.de, vkondra@...ileye.com
Subject: Re: [PATCH v5] panic: add panic_force_cpu= parameter to redirect
 panic to a specific CPU

On Thu,  8 Jan 2026 22:36:12 +0200
Pnina Feder <pnina.feder@...ileye.com> wrote:

First, new versions of a patch or patch set should *always* be a new thread
and not a reply to the old version. That makes it much harder on
maintainers to see a new series.

> If the specified CPU is invalid, offline, or a panic is already in
> progress on another CPU, the redirection is skipped and panic continues
> on the current CPU.
> 
> Changes since v4:
>  - Make IPI delivery an overridable weak function (panic_smp_redirect_cpu)
>    so architectures can use NMI where available
>  - Add declaration on include/linux/smp.h alongside other panic SMP functions
>  - Add warning to documentation about reduced reliability
>  - Address review comments from Andrew Morton (remove unnecessary cast,
>    add missing kernel-doc parameters)
> 
> Signed-off-by: Pnina Feder <pnina.feder@...ileye.com>
> ---

The "Changes since" line should always be below the '---' otherwise it gets
pulled into the git log and the maintainer needs to manually delete it
(which is annoying).

Also, it is helpful to add a link to the previous version.

> Signed-off-by: Pnina Feder <pnina.feder@...ileye.com>
> ---
 Changes since v4: https://lore.kernel.org/all/20260107215659.3619730-1-pnina.feder@mobileye.com/
  - Make IPI delivery an overridable weak function (panic_smp_redirect_cpu)
    so architectures can use NMI where available
  - Add declaration on include/linux/smp.h alongside other panic SMP functions
  - Add warning to documentation about reduced reliability
  - Address review comments from Andrew Morton (remove unnecessary cast,
    add missing kernel-doc parameters)

This provides the continuity between versions without having to be replies
of older versions.

-- Steve