linux-kernel - Re: [PATCH v2 1/2] arm: dts: aspeed: add an alt 128M flash layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d6aaf558fd8b60ec7010f976a747d9f0a727f98.camel@codeconstruct.com.au>
Date: Thu, 08 Jan 2026 16:34:57 +1030
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Marc Olberding <molberding@...dia.com>, Rob Herring <robh@...nel.org>, 
 Krzysztof Kozlowski
	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Joel Stanley
	 <joel@....id.au>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] arm: dts: aspeed: add an alt 128M flash layout

Hi Marc,

Regarding the subject prefix, can you please capitalise the 'ARM' portion, so:

   ARM: dts: aspeed: add an alt 128M flash layout

That way it's consistent with the rest of history.

On Thu, 2025-12-18 at 10:48 -0800, Marc Olberding wrote:
> Add a 128M layout for the BMC flash chip we didn't boot from. Including
> this allows the user to write to each partition on the alternate spi
> chip. This dtsi follows the existing standard of using the same layout
> as non alt version and prepending `alt` to each partition's name.
> 
> Testing: Include this in msx4 and cat size, offsets and name

I think this would be better with s/Testing/Tested by/ and associated
grammar fixes.

> ```
> for devdir in /sys/class/mtd/mtd*; do
> >     [[ -d $devdir && -r $devdir/name ]] || continue
> >     name=$(<"$devdir/name")
> >     [[ $name == alt* ]] || continue
> > 
> >     size=$(<"$devdir/size")
> >     offset=0
> >     [[ -r $devdir/offset ]] && offset=$(<"$devdir/offset")
> > 
> >     dev=$(basename "$devdir")
> >     printf "%s name=%s offset=0x%X size=0x%X\n" "$dev" "$name" \
> >        "$offset" "$size"
> > done
> mtd10 name=alt-rofs offset=0xA00000 size=0x5600000
> mtd11 name=alt-rwfs offset=0x6000000 size=0x2000000
> mtd7 name=alt-u-boot offset=0x0 size=0xE0000
> mtd8 name=alt-u-boot-env offset=0xE0000 size=0x20000
> mtd9 name=alt-kernel offset=0x100000 size=0x900000
> ```

Can you rather remove the markdown codeblock and instead indent the
code snippet (IMO 4 spaces is fine)?

Also the shell continuation markers seem a little unfortunate. Maybe
just drop them for clarity? You can separate the output from the
script.

I also found this helpful:

    diff -u arch/arm/boot/dts/aspeed/openbmc-flash-layout-128{,-alt}.dtsi

Andrew