[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aV97tR3AKxBVCBHr@ryzen>
Date: Thu, 8 Jan 2026 10:41:09 +0100
From: Niklas Cassel <cassel@...nel.org>
To: Koichiro Den <den@...inux.co.jp>
Cc: jingoohan1@...il.com, mani@...nel.org, lpieralisi@...nel.org,
kwilczynski@...nel.org, robh@...nel.org, bhelgaas@...gle.com,
Frank.Li@....com, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] PCI: endpoint: Add BAR subrange mapping support
On Thu, Jan 08, 2026 at 10:37:35AM +0100, Niklas Cassel wrote:
> @@ -596,6 +596,9 @@ int pci_epc_set_bar(struct pci_epc *epc, u8 func_no, u8 vfunc_no,
> if (!epc_features)
> return -EINVAL;
>
> + if (epf_bar->flags && !epc_features->subrange_mapping)
> + return -EINVAL;
This should of course have been:
if (epf_bar->use_submap && !epc_features->subrange_mapping)
return -EINVAL;
(I simply used flags in order to compile test without applying your series.)
Kind regards,
Niklas
Powered by blists - more mailing lists