linux-kernel - Re: [PATCH v2] iio: adc: ad7476: Remove duplicate include and sort the rest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vdiq0jhRV0SuQ9nT1NvSqnpv=3T6OPOLogkrT3f5kGt8A@mail.gmail.com>
Date: Thu, 8 Jan 2026 11:22:53 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Chen Ni <nichen@...as.ac.cn>
Cc: mazziesaccount@...il.com, lars@...afoo.de, Michael.Hennerich@...log.com, 
	jic23@...nel.org, dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org, 
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: adc: ad7476: Remove duplicate include and sort
 the rest

On Thu, Jan 8, 2026 at 10:41 AM Chen Ni <nichen@...as.ac.cn> wrote:
>
> Remove duplicate <linux/bitops.h> and sort all headers alphabetically.

I'm okay with this change, but I think ideally it would be three
patches in a series:
patch 1) as your v1;
patch 2) sorting the headers (as here);
patch 3) getting rid of "proxy" headers, e.g. kernel.h, by replacing
them with what actually is being used.

>  #include <linux/bitops.h>
> +#include <linux/delay.h>

>  #include <linux/device.h>

^^^ needs to be checked if it's used as a "proxy"

> +#include <linux/err.h>
> +#include <linux/gpio/consumer.h>

>  #include <linux/kernel.h>

^^^ This is for sure not used as is in the driver, so definitely has
to be replaced.

> +#include <linux/module.h>
> +#include <linux/regulator/consumer.h>
>  #include <linux/slab.h>
> -#include <linux/sysfs.h>
>  #include <linux/spi/spi.h>
> -#include <linux/regulator/consumer.h>
> -#include <linux/gpio/consumer.h>
> -#include <linux/err.h>
> -#include <linux/module.h>
> -#include <linux/bitops.h>
> -#include <linux/delay.h>
> +#include <linux/sysfs.h>

It's up to the maintainers and to you to resplit, send a v3, but
again, I'm fine with this version.

-- 
With Best Regards,
Andy Shevchenko