linux-kernel - Re: [PATCH v2] iio: adc: ad7476: Remove duplicate include and sort the rest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260111131814.649cd226@jic23-huawei>
Date: Sun, 11 Jan 2026 13:18:14 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Chen Ni <nichen@...as.ac.cn>, mazziesaccount@...il.com, lars@...afoo.de,
 Michael.Hennerich@...log.com, dlechner@...libre.com, nuno.sa@...log.com,
 andy@...nel.org, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: adc: ad7476: Remove duplicate include and sort
 the rest

On Thu, 8 Jan 2026 11:22:53 +0200
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Thu, Jan 8, 2026 at 10:41 AM Chen Ni <nichen@...as.ac.cn> wrote:
> >
> > Remove duplicate <linux/bitops.h> and sort all headers alphabetically.  
> 
> I'm okay with this change, but I think ideally it would be three
> patches in a series:
> patch 1) as your v1;
I picked up v1 for this reason.

> patch 2) sorting the headers (as here);
> patch 3) getting rid of "proxy" headers, e.g. kernel.h, by replacing
> them with what actually is being used.
Absolutely on these being good follow up steps.

> 
> >  #include <linux/bitops.h>
> > +#include <linux/delay.h>  
> 
> >  #include <linux/device.h>  
> 
> ^^^ needs to be checked if it's used as a "proxy"
> 
> > +#include <linux/err.h>
> > +#include <linux/gpio/consumer.h>  
> 
> >  #include <linux/kernel.h>  
> 
> ^^^ This is for sure not used as is in the driver, so definitely has
> to be replaced.
> 
> > +#include <linux/module.h>
> > +#include <linux/regulator/consumer.h>
> >  #include <linux/slab.h>
> > -#include <linux/sysfs.h>
> >  #include <linux/spi/spi.h>
> > -#include <linux/regulator/consumer.h>
> > -#include <linux/gpio/consumer.h>
> > -#include <linux/err.h>
> > -#include <linux/module.h>
> > -#include <linux/bitops.h>
> > -#include <linux/delay.h>
> > +#include <linux/sysfs.h>  
> 
> It's up to the maintainers and to you to resplit, send a v3, but
> again, I'm fine with this version.
I'd prefer the split as you have it above. As such I picked v1 up
to get patch 1 of that split up.

Thanks,

Jonathan

>