linux-kernel - Re: [RFT PATCH 1/2] arm64: dts: qcom: ipq5018: Correct USB DWC3 wrapper interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DS7PR19MB888371A31B691C9FD9E9042F9D85A@DS7PR19MB8883.namprd19.prod.outlook.com>
Date: Thu, 8 Jan 2026 13:42:50 +0400
From: George Moussalem <george.moussalem@...look.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFT PATCH 1/2] arm64: dts: qcom: ipq5018: Correct USB DWC3
 wrapper interrupts



On 1/6/26 22:51, Krzysztof Kozlowski wrote:
> Interrupts for DWC3 node were completely mixed up - SPI interrupt 62 is
> not listed in reference manual at all.  It was also causing dtbs_check
> warnings:
> 
>   ipq5018-rdp432-c2.dtb: usb@...8800 (qcom,ipq5018-dwc3): interrupt-names:0: 'pwr_event' was expected
>   ipq5018-rdp432-c2.dtb: usb@...8800 (qcom,ipq5018-dwc3): interrupt-names: ['hs_phy_irq'] is too short
> 
> Warning itself was introduced by commit 53c6d854be4e ("dt-bindings: usb:
> dwc3: Clean up hs_phy_irq in binding"), but this was trying to bring
> sanity to the interrupts overall, although did a mistake for IPQ5018.
> IPQ5018 does not have QUSB2 PHY and its interrupts should rather match
> ones used in IPQ5332.

No functional change, but USB port confirmed working on IPQ5018 device
Linksys MR5500. Thanks!

Tested-by: George Moussalem <george.moussalem@...look.com>

> 
> Correct it by using interrupts matching the bindings and reference
> manual.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
> 
> ---
> 
> Not tested on hardware.
> 
> Bindings for this change:
> lore.kernel.org/r/20260106185012.19551-3-krzysztof.kozlowski@....qualcomm.com
> ---
>  arch/arm64/boot/dts/qcom/ipq5018.dtsi | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> index 721b642acf8e..6f8004a22a1f 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> @@ -571,8 +571,12 @@ usb: usb@...8800 {
>  			compatible = "qcom,ipq5018-dwc3", "qcom,dwc3";
>  			reg = <0x08af8800 0x400>;
>  
> -			interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
> -			interrupt-names = "hs_phy_irq";
> +			interrupts = <GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "pwr_event",
> +					  "dp_hs_phy_irq",
> +					  "dm_hs_phy_irq";
>  
>  			clocks = <&gcc GCC_USB0_MASTER_CLK>,
>  				 <&gcc GCC_SYS_NOC_USB0_AXI_CLK>,