linux-kernel - Re: [PATCH v5 10/36] locking/mutex: Support Clang's context analysis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260109080715.0a390f6b@gandalf.local.home>
Date: Fri, 9 Jan 2026 08:07:15 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Christoph Hellwig <hch@....de>
Cc: Marco Elver <elver@...gle.com>, Bart Van Assche <bvanassche@....org>,
 Peter Zijlstra <peterz@...radead.org>, Boqun Feng <boqun.feng@...il.com>,
 Ingo Molnar <mingo@...nel.org>, Will Deacon <will@...nel.org>, "David S.
 Miller" <davem@...emloft.net>, Luc Van Oostenryck
 <luc.vanoostenryck@...il.com>, Chris Li <sparse@...isli.org>, "Paul E.
 McKenney" <paulmck@...nel.org>, Alexander Potapenko <glider@...gle.com>,
 Arnd Bergmann <arnd@...db.de>, Dmitry Vyukov <dvyukov@...gle.com>, Eric
 Dumazet <edumazet@...gle.com>, Frederic Weisbecker <frederic@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Herbert Xu
 <herbert@...dor.apana.org.au>, Ian Rogers <irogers@...gle.com>, Jann Horn
 <jannh@...gle.com>, Joel Fernandes <joelagnelf@...dia.com>, Johannes Berg
 <johannes.berg@...el.com>, Jonathan Corbet <corbet@....net>, Josh Triplett
 <josh@...htriplett.org>, Justin Stitt <justinstitt@...gle.com>, Kees Cook
 <kees@...nel.org>, Kentaro Takeda <takedakn@...data.co.jp>, Lukas Bulwahn
 <lukas.bulwahn@...il.com>, Mark Rutland <mark.rutland@....com>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, Miguel Ojeda
 <ojeda@...nel.org>, Nathan Chancellor <nathan@...nel.org>, Neeraj Upadhyay
 <neeraj.upadhyay@...nel.org>, Nick Desaulniers
 <nick.desaulniers+lkml@...il.com>, Tetsuo Handa
 <penguin-kernel@...ove.sakura.ne.jp>, Thomas Gleixner <tglx@...utronix.de>,
 Thomas Graf <tgraf@...g.ch>, Uladzislau Rezki <urezki@...il.com>, Waiman
 Long <longman@...hat.com>, kasan-dev@...glegroups.com,
 linux-crypto@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, linux-security-module@...r.kernel.org,
 linux-sparse@...r.kernel.org, linux-wireless@...r.kernel.org,
 llvm@...ts.linux.dev, rcu@...r.kernel.org
Subject: Re: [PATCH v5 10/36] locking/mutex: Support Clang's context
 analysis

On Fri, 9 Jan 2026 07:02:49 +0100
Christoph Hellwig <hch@....de> wrote:

> On Fri, Jan 09, 2026 at 12:26:55AM +0100, Marco Elver wrote:
> > Probably the most idiomatic option is to just factor out construction.
> > Clearly separating complex object construction from use also helps
> > readability regardless, esp. where concurrency is involved. We could
> > document such advice somewhere.  
> 
> Initializing and locking a mutex (or spinlock, or other primitive) is a
> not too unusual pattern, often used when inserting an object into a
> hash table or other lookup data structure.  So supporting it without
> creating pointless wrapper functions would be really useful.  One thing
> that would be nice to have and probably help here is to have lock
> initializers that create the lock in a held state.

Right. If tooling can't handle a simple pattern of initializing a lock than
taking it, that's a hard show stopper of adding that tooling.

-- Steve