linux-kernel - RE: [PATCH] scsi: storvsc: Process unsupported MODE_SENSE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SN6PR02MB4157232BE7BB9B6B1AA81AEBD482A@SN6PR02MB4157.namprd02.prod.outlook.com>
Date: Fri, 9 Jan 2026 17:48:38 +0000
From: Michael Kelley <mhklinux@...look.com>
To: "longli@...ux.microsoft.com" <longli@...ux.microsoft.com>, "K. Y.
 Srinivasan" <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Wei
 Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>, "James E.J.
 Bottomley" <James.Bottomley@...senPartnership.com>, "Martin K. Petersen"
	<martin.petersen@...cle.com>, James Bottomley <JBottomley@...n.com>,
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: Long Li <longli@...rosoft.com>, "stable@...nel.org" <stable@...nel.org>
Subject: RE: [PATCH] scsi: storvsc: Process unsupported MODE_SENSE_10

From: longli@...ux.microsoft.com <longli@...ux.microsoft.com> Sent: Wednesday, January 7, 2026 11:57 AM
> 
> The Hyper-V host does not support MODE_SENSE_10 and MODE_SENSE.
> The driver handles MODE_SENSE as unsupported command, but not for
> MODE_SENSE_10. Add MODE_SENSE_10 to the same handling logic and
> return correct code to SCSI layer.
> 
> Fixes: 89ae7d709357 ("Staging: hv: storvsc: Move the storage driver out of the staging area")
> Cc: stable@...nel.org
> Signed-off-by: Long Li <longli@...rosoft.com>
> ---
>  drivers/scsi/storvsc_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 6e4112143c76..9b15784e2d64 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1154,6 +1154,7 @@ static void storvsc_on_io_completion(struct storvsc_device
> *stor_device,
> 
>  	if ((stor_pkt->vm_srb.cdb[0] == INQUIRY) ||
>  	   (stor_pkt->vm_srb.cdb[0] == MODE_SENSE) ||
> +	   (stor_pkt->vm_srb.cdb[0] == MODE_SENSE_10) ||
>  	   (stor_pkt->vm_srb.cdb[0] == MAINTENANCE_IN &&
>  	   hv_dev_is_fc(device))) {
>  		vstor_packet->vm_srb.scsi_status = 0;

There's a code comment above this "if" statement that describes the situation.
The comment specifically lists INQUIRY, MODE_SENSE, and MAINTENANCE_IN. For
consistency, it should be updated to include MODE_SENSE_10.

With the comment updated,

Reviewed-by: Michael Kelley <mhklinux@...look.com>