[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<DS3PR21MB57351CF7BDEF314AA21E2CC4CE81A@DS3PR21MB5735.namprd21.prod.outlook.com>
Date: Mon, 12 Jan 2026 17:52:58 +0000
From: Long Li <longli@...rosoft.com>
To: Michael Kelley <mhklinux@...look.com>, "longli@...ux.microsoft.com"
<longli@...ux.microsoft.com>, KY Srinivasan <kys@...rosoft.com>, Haiyang
Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, Dexuan Cui
<DECUI@...rosoft.com>, "James E.J. Bottomley"
<James.Bottomley@...senPartnership.com>, "Martin K. Petersen"
<martin.petersen@...cle.com>, James Bottomley <JBottomley@...n.com>,
"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "stable@...nel.org" <stable@...nel.org>
Subject: RE: [PATCH] scsi: storvsc: Process unsupported MODE_SENSE_10
> > @@ -1154,6 +1154,7 @@ static void storvsc_on_io_completion(struct
> > storvsc_device *stor_device,
> >
> > if ((stor_pkt->vm_srb.cdb[0] == INQUIRY) ||
> > (stor_pkt->vm_srb.cdb[0] == MODE_SENSE) ||
> > + (stor_pkt->vm_srb.cdb[0] == MODE_SENSE_10) ||
> > (stor_pkt->vm_srb.cdb[0] == MAINTENANCE_IN &&
> > hv_dev_is_fc(device))) {
> > vstor_packet->vm_srb.scsi_status = 0;
>
> There's a code comment above this "if" statement that describes the situation.
> The comment specifically lists INQUIRY, MODE_SENSE, and
> MAINTENANCE_IN. For consistency, it should be updated to include
> MODE_SENSE_10.
>
> With the comment updated,
>
> Reviewed-by: Michael Kelley <mhklinux@...look.com>
Will send v2, thank you.
Long
Powered by blists - more mailing lists