linux-kernel - Re: [PATCH v1] arm64: defconfig: enable WCD937X codec driver as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ea79961-7cc8-48be-a2fe-84303a570fb7@oss.qualcomm.com>
Date: Fri, 9 Jan 2026 13:03:58 +0530
From: Ajay Kumar Nandam <ajay.nandam@....qualcomm.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Bjorn Andersson <bjorn.andersson@....qualcomm.com>,
        Arnd Bergmann <arnd@...db.de>, Heiko Stuebner <heiko@...ech.de>,
        Eric Biggers <ebiggers@...nel.org>,
        Michal Simek <michal.simek@....com>,
        Luca Weiss <luca.weiss@...rphone.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc: linux-kernel@...r.kernel.org, mohammad.rafi.shaik@....qualcomm.com,
        ravi.hothi@....qualcomm.com
Subject: Re: [PATCH v1] arm64: defconfig: enable WCD937X codec driver as
 module



On 1/8/2026 1:12 PM, Krzysztof Kozlowski wrote:
> On 08/01/2026 08:41, Krzysztof Kozlowski wrote:
>> On 08/01/2026 08:34, Ajay Kumar Nandam wrote:
>>> Enable the Qualcomm WCD937X SoundWire codec driver as a
>>> loadable module in the arm64 defconfig. This is required for
>>> audio support on platforms using the WCD937X codec over the
>>> SoundWire interface.
>>
>> Not a good reason. You wrote four lines of which all are redundant,
>> because you still did not prove we need to have support for WCD937x
>> Soundwire interface.

Ack, I will rework the commit message accordingly.

>>
>>>
>>> Signed-off-by: Ajay Kumar Nandam <ajay.nandam@....qualcomm.com>
>>> ---
>>
>>
>> Look incomplete.
>>
>> https://lore.kernel.org/all/20240916052352.1819088-1-quic_mohs@quicinc.com/
>> https://lore.kernel.org/all/20241010052646.2597418-1-quic_mohs@quicinc.com/
>> https://lore.kernel.org/all/20241007082312.2136358-1-quic_mohs@quicinc.com/
>>
>> https://lore.kernel.org/all/?q=CONFIG_SND_SOC_WCD937X_SDW
>>
>> But anyway, you did the same as all patches before, so it won't be
>> applied. There is really no point in sending the same three four times.
>> Nothing will change, no one will apply it, unless you finally fix the
>> address list.
>>
>> You also Cc-ed here completely random addresses... E.g. why is this
>> relevant to Xilinx?

ack,

will resend an updated version with the correct maintainer and mailing 
list CCs added using get_maintainer.pl for the relevant SoC.

Previously, I ran get_maintainer.pl on the arm64 defconfig instead of on 
the SoC‑specific, which resulted in an incomplete and incorrect address 
list. I will ensure this is done correctly going forward.

Thanks
Ajay kumar Nandam

> 
> 
> And I already said all this so you could have build on previous feedback
> instead of repeating exactly same two mistakes.
> 
> https://lore.kernel.org/all/638a44fc-c693-4270-8643-7cd75a3c6ba6@linaro.org/
> 
> Best regards,
> Krzysztof