linux-kernel - Re: [PATCH v2 1/2] dt-bindings: iio: dac: Add max22007

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260109-frisky-giga-ammonite-3fd8ca@quoll>
Date: Fri, 9 Jan 2026 09:26:25 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Janani Sunil <janani.sunil@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, 
	Michael Hennerich <Michael.Hennerich@...log.com>, Alexandru Ardelean <alexandru.ardelean@...log.com>, 
	Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Jonathan Corbet <corbet@....net>, linux-iio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, jan.sun97@...il.com
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: dac: Add max22007

On Thu, Jan 08, 2026 at 01:58:23PM +0100, Janani Sunil wrote:
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +  - hvdd-supply
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/iio/addac/adi,ad74413r.h>
> +
> +    vdd_reg: regulator-vdd {

This was not here, drop entire node.

> +        compatible = "regulator-fixed";
> +        regulator-name = "vdd-3v3";
> +        regulator-min-microvolt = <3300000>;
> +        regulator-max-microvolt = <3300000>;
> +        regulator-always-on;
> +    };
> +
> +    hvdd_reg: regulator-hvdd {

Same here.


With these two fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

Best regards,
Krzysztof