[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMRc=McFDfVjpEBGzRpWiyH0D4q2eOApKZrJLFgh_UXQ=tDNMA@mail.gmail.com>
Date: Fri, 9 Jan 2026 09:31:30 +0100
From: Bartosz Golaszewski <brgl@...nel.org>
To: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
Cc: linusw@...nel.org, andriy.shevchenko@...el.com,
dev-jorge.sanjuangarcia@...gon.com, linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] gpio: gpio-menz127: drop unneeded MODULE_ALIAS
On Thu, Jan 8, 2026 at 2:49 PM Jose Javier Rodriguez Barbarin
<dev-josejavier.rodriguez@...gon.com> wrote:
>
> Since commit 1f4ea4838b13 ("mcb: Add missing modpost build support")
> the MODULE_ALIAS() is redundant as the module alias is now
> automatically generated from the MODULE_DEVICE_TABLE().
>
> Remove the explicit alias.
>
> No functional change intended.
>
> Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@...gon.com>
> Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
> ---
And what are the changes vs v1?
Bart
> drivers/gpio/gpio-menz127.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-menz127.c b/drivers/gpio/gpio-menz127.c
> index 52b13c6ae496..f51e7517f551 100644
> --- a/drivers/gpio/gpio-menz127.c
> +++ b/drivers/gpio/gpio-menz127.c
> @@ -223,5 +223,4 @@ module_mcb_driver(men_z127_driver);
> MODULE_AUTHOR("Andreas Werner <andreas.werner@....de>");
> MODULE_DESCRIPTION("MEN GPIO Controller");
> MODULE_LICENSE("GPL v2");
> -MODULE_ALIAS("mcb:16z127");
> MODULE_IMPORT_NS("MCB");
> --
> 2.52.0
Powered by blists - more mailing lists