linux-kernel - Re: [PATCH v2 1/1] gpio: gpio-menz127: drop unneeded MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWDm4pjW83yta2Mx@MNI-190>
Date: Fri, 9 Jan 2026 12:30:42 +0100
From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
To: Bartosz Golaszewski <brgl@...nel.org>
CC: linusw@...nel.org, andriy.shevchenko@...el.com,
	dev-jorge.sanjuangarcia@...gon.com, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] gpio: gpio-menz127: drop unneeded MODULE_ALIAS

On Fri, Jan 09, 2026 at 09:31:30AM +0100, Bartosz Golaszewski wrote:
> On Thu, Jan 8, 2026 at 2:49 PM Jose Javier Rodriguez Barbarin
> <dev-josejavier.rodriguez@...gon.com> wrote:
> >
> > Since commit 1f4ea4838b13 ("mcb: Add missing modpost build support")
> > the MODULE_ALIAS() is redundant as the module alias is now
> > automatically generated from the MODULE_DEVICE_TABLE().
> >
> > Remove the explicit alias.
> >
> > No functional change intended.
> >
> > Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@...gon.com>
> > Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@...gon.com>
> > ---
> 
> And what are the changes vs v1?

Hi Bartosz,

Thank you for your answer.

There is no changes in the code between v1 and v2. As I wrote in the cover
letter, the change for v2 is basically the commit renaming.

I know sending v2 without changes is not strictly correct but I decided to do that
because I make some mistakes the first time and I would like to clarify that. 

I failed in first patch series submission as not all people involved received the
cover letter (among other mistakes) so I decided to send each patch as v2
(with its cover letter) to the correct people and mailing lists.

> 
> Bart
> 
> >  drivers/gpio/gpio-menz127.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpio/gpio-menz127.c b/drivers/gpio/gpio-menz127.c
> > index 52b13c6ae496..f51e7517f551 100644
> > --- a/drivers/gpio/gpio-menz127.c
> > +++ b/drivers/gpio/gpio-menz127.c
> > @@ -223,5 +223,4 @@ module_mcb_driver(men_z127_driver);
> >  MODULE_AUTHOR("Andreas Werner <andreas.werner@....de>");
> >  MODULE_DESCRIPTION("MEN GPIO Controller");
> >  MODULE_LICENSE("GPL v2");
> > -MODULE_ALIAS("mcb:16z127");
> >  MODULE_IMPORT_NS("MCB");
> > --
> > 2.52.0

Regards,

Javier R.