linux-kernel - Re: [PATCH v9 loongarch-next 1/4] LoongArch: Replace seq_printf with seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H4gPS5XhRmsFgsb2nofi1kNSC4qyxtYsWTgHkuP9t79LA@mail.gmail.com>
Date: Sat, 10 Jan 2026 12:11:31 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: George Guo <dongtai.guo@...ux.dev>
Cc: hengqi.chen@...il.com, kernel@...0n.name, lianyangyang@...inos.cn, 
	linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev, r@....cc, 
	xry111@...111.site, George Guo <guodongtai@...inos.cn>
Subject: Re: [PATCH v9 loongarch-next 1/4] LoongArch: Replace seq_printf with
 seq_puts for simple strings

Hi, George,

On Mon, Jan 5, 2026 at 6:55 PM George Guo <dongtai.guo@...ux.dev> wrote:
>
> From: George Guo <guodongtai@...inos.cn>
>
> Fix warnings like: "Prefer seq_puts to seq_printf" by checkpatch.pl.
Please move this patch to be the last one, because it is not the keystone.


Huacai
>
> Replace seq_printf() calls with seq_puts() in show_cpuinfo()
> when outputting simple constant strings without format specifiers.
>
> This improves performance slightly as seq_puts() avoids parsing
> the format string.
>
> Signed-off-by: George Guo <guodongtai@...inos.cn>
> ---
>  arch/loongarch/kernel/proc.c | 61 ++++++++++++++++++++++--------------
>  1 file changed, 38 insertions(+), 23 deletions(-)
>
> diff --git a/arch/loongarch/kernel/proc.c b/arch/loongarch/kernel/proc.c
> index a8800d20e11b..1d646da010f9 100644
> --- a/arch/loongarch/kernel/proc.c
> +++ b/arch/loongarch/kernel/proc.c
> @@ -50,32 +50,47 @@ static int show_cpuinfo(struct seq_file *m, void *v)
>         seq_printf(m, "Address Sizes\t\t: %d bits physical, %d bits virtual\n",
>                       cpu_pabits + 1, cpu_vabits + 1);
>
> -       seq_printf(m, "ISA\t\t\t:");
> +       seq_puts(m, "ISA\t\t\t:");
>         if (isa & LOONGARCH_CPU_ISA_LA32R)
> -               seq_printf(m, " loongarch32r");
> +               seq_puts(m, " loongarch32r");
>         if (isa & LOONGARCH_CPU_ISA_LA32S)
> -               seq_printf(m, " loongarch32s");
> +               seq_puts(m, " loongarch32s");
>         if (isa & LOONGARCH_CPU_ISA_LA64)
> -               seq_printf(m, " loongarch64");
> -       seq_printf(m, "\n");
> +               seq_puts(m, " loongarch64");
> +       seq_puts(m, "\n");
>
> -       seq_printf(m, "Features\t\t:");
> -       if (cpu_has_cpucfg)     seq_printf(m, " cpucfg");
> -       if (cpu_has_lam)        seq_printf(m, " lam");
> -       if (cpu_has_ual)        seq_printf(m, " ual");
> -       if (cpu_has_fpu)        seq_printf(m, " fpu");
> -       if (cpu_has_lsx)        seq_printf(m, " lsx");
> -       if (cpu_has_lasx)       seq_printf(m, " lasx");
> -       if (cpu_has_crc32)      seq_printf(m, " crc32");
> -       if (cpu_has_complex)    seq_printf(m, " complex");
> -       if (cpu_has_crypto)     seq_printf(m, " crypto");
> -       if (cpu_has_ptw)        seq_printf(m, " ptw");
> -       if (cpu_has_lspw)       seq_printf(m, " lspw");
> -       if (cpu_has_lvz)        seq_printf(m, " lvz");
> -       if (cpu_has_lbt_x86)    seq_printf(m, " lbt_x86");
> -       if (cpu_has_lbt_arm)    seq_printf(m, " lbt_arm");
> -       if (cpu_has_lbt_mips)   seq_printf(m, " lbt_mips");
> -       seq_printf(m, "\n");
> +       seq_puts(m, "Features\t\t:");
> +       if (cpu_has_cpucfg)
> +               seq_puts(m, " cpucfg");
> +       if (cpu_has_lam)
> +               seq_puts(m, " lam");
> +       if (cpu_has_ual)
> +               seq_puts(m, " ual");
> +       if (cpu_has_fpu)
> +               seq_puts(m, " fpu");
> +       if (cpu_has_lsx)
> +               seq_puts(m, " lsx");
> +       if (cpu_has_lasx)
> +               seq_puts(m, " lasx");
> +       if (cpu_has_crc32)
> +               seq_puts(m, " crc32");
> +       if (cpu_has_complex)
> +               seq_puts(m, " complex");
> +       if (cpu_has_crypto)
> +               seq_puts(m, " crypto");
> +       if (cpu_has_ptw)
> +               seq_puts(m, " ptw");
> +       if (cpu_has_lspw)
> +               seq_puts(m, " lspw");
> +       if (cpu_has_lvz)
> +               seq_puts(m, " lvz");
> +       if (cpu_has_lbt_x86)
> +               seq_puts(m, " lbt_x86");
> +       if (cpu_has_lbt_arm)
> +               seq_puts(m, " lbt_arm");
> +       if (cpu_has_lbt_mips)
> +               seq_puts(m, " lbt_mips");
> +       seq_puts(m, "\n");
>
>         seq_printf(m, "Hardware Watchpoint\t: %s", str_yes_no(cpu_has_watch));
>         if (cpu_has_watch) {
> @@ -83,7 +98,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)
>                       cpu_data[n].watch_ireg_count, cpu_data[n].watch_dreg_count);
>         }
>
> -       seq_printf(m, "\n\n");
> +       seq_puts(m, "\n\n");
>
>         return 0;
>  }
> --
> 2.43.0
>
>