linux-kernel - Re: [PATCH 2/2] net: axienet: Fix resource release ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260110115306.4049b2cb@kernel.org>
Date: Sat, 10 Jan 2026 11:53:06 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Suraj Gupta <suraj.gupta2@....com>
Cc: <mturquette@...libre.com>, <sboyd@...nel.org>,
 <radhey.shyam.pandey@....com>, <andrew+netdev@...n.ch>,
 <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <michal.simek@....com>, <sean.anderson@...ux.dev>, <linux@...linux.org.uk>,
 <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
 <bmasney@...hat.com>
Subject: Re: [PATCH 2/2] net: axienet: Fix resource release ordering

On Fri, 9 Jan 2026 12:40:51 +0530 Suraj Gupta wrote:
> Device-managed resources are released after manually-managed resources.
> Therefore, once any manually-managed resource is acquired, all further
> resources must be manually-managed too.

only for resources which have dependencies. Please include in the commit
message what exactly is going wrong in this driver. The commit under
Fixes seems to be running ioremap, I don't see how that matters vs
netdev allocation for example..

> Convert all resources before the MDIO bus is created into device-managed
> resources. In all cases but one there are already devm variants available.
-- 
pw-bot: cr