linux-kernel - Re: [PATCH 2/2] net: axienet: Fix resource release ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6499ec9-92d3-4a63-8172-3c09a8b64066@linux.dev>
Date: Mon, 12 Jan 2026 09:53:28 -0500
From: Sean Anderson <sean.anderson@...ux.dev>
To: Jakub Kicinski <kuba@...nel.org>, Suraj Gupta <suraj.gupta2@....com>
Cc: mturquette@...libre.com, sboyd@...nel.org, radhey.shyam.pandey@....com,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, michal.simek@....com, linux@...linux.org.uk,
 linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 bmasney@...hat.com
Subject: Re: [PATCH 2/2] net: axienet: Fix resource release ordering

On 1/10/26 14:53, Jakub Kicinski wrote:
> On Fri, 9 Jan 2026 12:40:51 +0530 Suraj Gupta wrote:
>> Device-managed resources are released after manually-managed resources.
>> Therefore, once any manually-managed resource is acquired, all further
>> resources must be manually-managed too.
> 
> only for resources which have dependencies. Please include in the commit
> message what exactly is going wrong in this driver. The commit under
> Fixes seems to be running ioremap, I don't see how that matters vs
> netdev allocation for example..

In the series I originally submitted this in, I wanted to add a devm
resources (mdio bus etc.) at the end of probe that required the clocks
to be running. But as a standalone patch this is more of a cleanup.

>> Convert all resources before the MDIO bus is created into device-managed
>> resources. In all cases but one there are already devm variants available.