linux-kernel - RE: [PATCH 2/2] net: axienet: Fix resource release ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SA1PR12MB6798EE87AC8F1C0E181D57CCC98EA@SA1PR12MB6798.namprd12.prod.outlook.com>
Date: Tue, 13 Jan 2026 05:32:26 +0000
From: "Gupta, Suraj" <Suraj.Gupta2@....com>
To: Sean Anderson <sean.anderson@...ux.dev>, Jakub Kicinski <kuba@...nel.org>
CC: "mturquette@...libre.com" <mturquette@...libre.com>, "sboyd@...nel.org"
	<sboyd@...nel.org>, "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "Simek, Michal"
	<michal.simek@....com>, "linux@...linux.org.uk" <linux@...linux.org.uk>,
	"linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "bmasney@...hat.com"
	<bmasney@...hat.com>
Subject: RE: [PATCH 2/2] net: axienet: Fix resource release ordering

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: Sean Anderson <sean.anderson@...ux.dev>
> Sent: Monday, January 12, 2026 8:23 PM
> To: Jakub Kicinski <kuba@...nel.org>; Gupta, Suraj <Suraj.Gupta2@....com>
> Cc: mturquette@...libre.com; sboyd@...nel.org; Pandey, Radhey Shyam
> <radhey.shyam.pandey@....com>; andrew+netdev@...n.ch;
> davem@...emloft.net; edumazet@...gle.com; pabeni@...hat.com; Simek,
> Michal <michal.simek@....com>; linux@...linux.org.uk; linux-
> clk@...r.kernel.org; linux-kernel@...r.kernel.org; netdev@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; bmasney@...hat.com
> Subject: Re: [PATCH 2/2] net: axienet: Fix resource release ordering
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On 1/10/26 14:53, Jakub Kicinski wrote:
> > On Fri, 9 Jan 2026 12:40:51 +0530 Suraj Gupta wrote:
> >> Device-managed resources are released after manually-managed resources.
> >> Therefore, once any manually-managed resource is acquired, all
> >> further resources must be manually-managed too.
> >
> > only for resources which have dependencies. Please include in the
> > commit message what exactly is going wrong in this driver. The commit
> > under Fixes seems to be running ioremap, I don't see how that matters
> > vs netdev allocation for example..
>
> In the series I originally submitted this in, I wanted to add a devm resources
> (mdio bus etc.) at the end of probe that required the clocks to be running. But
> as a standalone patch this is more of a cleanup.
>

Thanks Sean, I will modify the commit description accordingly and mention only the conversion to the `devm` version of the clock and netdev allocation APIs.

Regards,
Suraj

> >> Convert all resources before the MDIO bus is created into
> >> device-managed resources. In all cases but one there are already devm
> variants available.