linux-kernel - Re: [PATCH] mm/khugepaged: make khugepaged_collapse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49229782-acf5-4e33-b317-63399deb6f6d@lucifer.local>
Date: Mon, 12 Jan 2026 16:33:42 +0000
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Ben Dooks <ben.dooks@...ethink.co.uk>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org, david@...nel.org
Subject: Re: [PATCH] mm/khugepaged: make khugepaged_collapse_control static

On Mon, Jan 12, 2026 at 04:18:20PM +0000, Ben Dooks wrote:
> Make khugepaged_collapse_control as it is not exported.
> Fixes the following sparse warning:
>
> mm/khugepaged.c:829:25: warning: symbol 'khugepaged_collapse_control' was not declared. Should it be static?

Thanks for the patch, but sorry to say that this has already been addressed in
[0].

[0]: https://lore.kernel.org/all/20251224111351.41042-14-shivankg@amd.com/

>
> Fixes: 34d6b470ab9cf ("mm/khugepaged: add struct collapse_control")

(Small note: for something like this that isn't fixing an actual bug we don't
use a fixes like this).

> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> ---
>  mm/khugepaged.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index 97d1b2824386..c9bd0df632bd 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -826,7 +826,7 @@ static void khugepaged_alloc_sleep(void)
>  	remove_wait_queue(&khugepaged_wait, &wait);
>  }
>
> -struct collapse_control khugepaged_collapse_control = {
> +static struct collapse_control khugepaged_collapse_control = {
>  	.is_khugepaged = true,
>  };
>
> --
> 2.37.2.352.g3c44437643
>

Cheers, Lorenzo