linux-kernel - Re: [PATCH] mm/khugepaged: make khugepaged_collapse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a289c18-b5b7-497c-bd6d-a25602706b23@codethink.co.uk>
Date: Tue, 13 Jan 2026 09:26:37 +0000
From: Ben Dooks <ben.dooks@...ethink.co.uk>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 akpm@...ux-foundation.org, david@...nel.org
Subject: Re: [PATCH] mm/khugepaged: make khugepaged_collapse_control static

On 12/01/2026 16:33, Lorenzo Stoakes wrote:
> On Mon, Jan 12, 2026 at 04:18:20PM +0000, Ben Dooks wrote:
>> Make khugepaged_collapse_control as it is not exported.
>> Fixes the following sparse warning:
>>
>> mm/khugepaged.c:829:25: warning: symbol 'khugepaged_collapse_control' was not declared. Should it be static?
> 
> Thanks for the patch, but sorry to say that this has already been addressed in
> [0].
> 
> [0]: https://lore.kernel.org/all/20251224111351.41042-14-shivankg@amd.com/
> 
>>
>> Fixes: 34d6b470ab9cf ("mm/khugepaged: add struct collapse_control")
> 
> (Small note: for something like this that isn't fixing an actual bug we don't
> use a fixes like this).

Is this a subsystem preference because I was told I needed it for other
patches.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html