linux-kernel - Re: [PATCH] Documentation: KVM: Formalizing taking vcpu->mutex *outside* of kvm->slots

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <176823892636.1370730.5324133186861069066.b4-ty@google.com>
Date: Mon, 12 Jan 2026 09:38:36 -0800
From: Sean Christopherson <seanjc@...gle.com>
To: Sean Christopherson <seanjc@...gle.com>, Paolo Bonzini <pbonzini@...hat.com>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Marc Zyngier <maz@...nel.org>, Oliver Upton <oupton@...nel.org>
Subject: Re: [PATCH] Documentation: KVM: Formalizing taking vcpu->mutex
 *outside* of kvm->slots_lock

On Thu, 16 Oct 2025 16:55:38 -0700, Sean Christopherson wrote:
> Explicitly document the ordering of vcpu->mutex being taken *outside* of
> kvm->slots_lock.  While extremely unintuitive, and arguably wrong, both
> arm64 and x86 have gained flows that take kvm->slots_lock inside of
> vcpu->mutex.  x86's kvm_inhibit_apic_access_page() is particularly
> nasty, as slots_lock is taken quite deep within KVM_RUN, i.e. simply
> swapping the ordering isn't an option.
> 
> [...]

Applied to kvm-x86 generic, thanks!

[1/1] Documentation: KVM: Formalizing taking vcpu->mutex *outside* of kvm->slots_lock
      https://github.com/kvm-x86/linux/commit/98333091750d

--
https://github.com/kvm-x86/linux/tree/next