Message-ID: <6BB4F74A-F440-4F21-B094-62CFD18C599A@gmail.com>
Date: Mon, 12 Jan 2026 09:40:09 -0800
From: "Derek J. Clark" <derekjohn.clark@...il.com>
To: Jiri Kosina <jikos@...nel.org>
CC: Benjamin Tissoires <bentiss@...nel.org>,
 Mario Limonciello <mario.limonciello@....com>,
 Zhixin Zhang <zhangzx36@...ovo.com>, Mia Shao <shaohz1@...ovo.com>,
 Mark Pearson <mpearson-lenovo@...ebb.ca>,
 "Pierre-Loup A . Griffais" <pgriffais@...vesoftware.com>,
 linux-input@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/16] HID: hid-lenovo-go: Add Lenovo Legion Go Series HID Driver

On January 12, 2026 4:12:43 AM PST, Jiri Kosina <jikos@...nel.org> wrote:
>On Mon, 29 Dec 2025, Derek J. Clark wrote:
>
>> Adds initial framework for a new HID driver, hid-lenovo-go, along with
>> attributes that report the firmware and hardware version for each
>> component of the HID device, of which there are 4 parts: The MCU, the
>> transmission dongle, the left "handle" controller half, and the right
>> "handle" controller half. Each of these devices are provided an attribute
>> group to contain its device specific attributes. Additionally, the touchpad
>> device attributes are logically separated from the other components in
>> another attribute group.
>> 
>> This driver primarily provides access to the configurable settings of the
>> Lenovo Legion Go and Lenovo Legion Go 2 controllers running the latest
>> firmware. As previously noted, the Legion Go controllers recently had a
>> firmware update[1] which switched from the original "SepentiaUSB" protocol
>> to a brand new protocol for the Go 2, primarily to ensure backwards and
>> forwards compatibility between the Go and Go 2 devices. As part of that
>> update the PIDs for the controllers were changed, so there is no risk of
>> this driver attaching to controller firmware that it doesn't support.
>> 
>> Signed-off-by: Derek J. Clark <derekjohn.clark@...il.com>
>> ---
>>  MAINTAINERS                 |   6 +
>>  drivers/hid/Kconfig         |  12 +
>>  drivers/hid/Makefile        |   1 +
>>  drivers/hid/hid-ids.h       |   3 +
>>  drivers/hid/hid-lenovo-go.c | 734 ++++++++++++++++++++++++++++++++++++
>>  5 files changed, 756 insertions(+)
>>  create mode 100644 drivers/hid/hid-lenovo-go.c
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 9ed6d11a7746..b5ad29d24e3e 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -14135,6 +14135,12 @@ L:	platform-driver-x86@...r.kernel.org
>>  S:	Maintained
>>  F:	drivers/platform/x86/lenovo/wmi-hotkey-utilities.c
>>  
>> +LENOVO HID drivers
>> +M:	Derek J. Clark <derekjohn.clark@...il.com>
>> +L:	linux-input@...r.kernel.org
>> +S:	Maintained
>> +F:	drivers/hid/hid-lenovo-go.c
>
>Hi Derek,
>
>thanks for working on this.
>
>I am now almost finished with reviewing this pile and am planning to queue 
>it in hid.git shortly, but I have a question regarding the MAINTAINERS 
>entry above.
>
>The title claims support for all of Lenovo HID, but there is much more to 
>it than drivers/hid/hid-lenovo-go.c, specifically in hid-lenovo.c.
>
>So either please make the title more specific (or claim the ownership of 
>the whole Lenovo HID landscape indeed, fine by me, but the please reflect 
>that in F: :) ).
>
>Thanks,
>

Hi Jiri

Sure, I've debated using LENOVO LEGION GO HID drivers and LENOVO GO HID drivers. Do you have a preference? The other drivers are pretty old and I don't have any hardware that would use them so I'd prefer to keep them separate (though I'll acknowledge that they don't seem to have a MAINTAINERS entry)

I also need to fix the ABI docs, I accidentally added an extra + character to every line in the patch for both. I'll update that too when I fix this.

Thanks,
Derek

Powered by blists - more mailing lists