linux-kernel - Re: [PATCH v2 02/16] HID: hid-lenovo-go: Add Lenovo Legion Go Series HID Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <2910bb2e-6b31-42f3-a3de-463327b16ff1@app.fastmail.com>
Date: Mon, 12 Jan 2026 13:20:26 -0500
From: "Mark Pearson" <mpearson-lenovo@...ebb.ca>
To: "Derek J . Clark" <derekjohn.clark@...il.com>,
 "Jiri Kosina" <jikos@...nel.org>
Cc: "Benjamin Tissoires" <bentiss@...nel.org>,
 "Limonciello, Mario" <mario.limonciello@....com>,
 "Zhixin Zhang" <zhangzx36@...ovo.com>, "Mia Shao" <shaohz1@...ovo.com>,
 "Pierre-Loup A . Griffais" <pgriffais@...vesoftware.com>,
 linux-input@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/16] HID: hid-lenovo-go: Add Lenovo Legion Go Series HID
 Driver

On Mon, Jan 12, 2026, at 12:40 PM, Derek J. Clark wrote:
> On January 12, 2026 4:12:43 AM PST, Jiri Kosina <jikos@...nel.org> wrote:
>>On Mon, 29 Dec 2025, Derek J. Clark wrote:
>>
>>> Adds initial framework for a new HID driver, hid-lenovo-go, along with
>>> attributes that report the firmware and hardware version for each
>>> component of the HID device, of which there are 4 parts: The MCU, the
>>> transmission dongle, the left "handle" controller half, and the right
>>> "handle" controller half. Each of these devices are provided an attribute
>>> group to contain its device specific attributes. Additionally, the touchpad
>>> device attributes are logically separated from the other components in
>>> another attribute group.
>>> 
>>> This driver primarily provides access to the configurable settings of the
>>> Lenovo Legion Go and Lenovo Legion Go 2 controllers running the latest
>>> firmware. As previously noted, the Legion Go controllers recently had a
>>> firmware update[1] which switched from the original "SepentiaUSB" protocol
>>> to a brand new protocol for the Go 2, primarily to ensure backwards and
>>> forwards compatibility between the Go and Go 2 devices. As part of that
>>> update the PIDs for the controllers were changed, so there is no risk of
>>> this driver attaching to controller firmware that it doesn't support.
>>> 
>>> Signed-off-by: Derek J. Clark <derekjohn.clark@...il.com>
>>> ---
>>>  MAINTAINERS                 |   6 +
>>>  drivers/hid/Kconfig         |  12 +
>>>  drivers/hid/Makefile        |   1 +
>>>  drivers/hid/hid-ids.h       |   3 +
>>>  drivers/hid/hid-lenovo-go.c | 734 ++++++++++++++++++++++++++++++++++++
>>>  5 files changed, 756 insertions(+)
>>>  create mode 100644 drivers/hid/hid-lenovo-go.c
>>> 
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 9ed6d11a7746..b5ad29d24e3e 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -14135,6 +14135,12 @@ L:	platform-driver-x86@...r.kernel.org
>>>  S:	Maintained
>>>  F:	drivers/platform/x86/lenovo/wmi-hotkey-utilities.c
>>>  
>>> +LENOVO HID drivers
>>> +M:	Derek J. Clark <derekjohn.clark@...il.com>
>>> +L:	linux-input@...r.kernel.org
>>> +S:	Maintained
>>> +F:	drivers/hid/hid-lenovo-go.c
>>
>>Hi Derek,
>>
>>thanks for working on this.
>>
>>I am now almost finished with reviewing this pile and am planning to queue 
>>it in hid.git shortly, but I have a question regarding the MAINTAINERS 
>>entry above.
>>
>>The title claims support for all of Lenovo HID, but there is much more to 
>>it than drivers/hid/hid-lenovo-go.c, specifically in hid-lenovo.c.
>>
>>So either please make the title more specific (or claim the ownership of 
>>the whole Lenovo HID landscape indeed, fine by me, but the please reflect 
>>that in F: :) ).
>>
>>Thanks,
>>
>
> Hi Jiri
>
> Sure, I've debated using LENOVO LEGION GO HID drivers and LENOVO GO HID 
> drivers. Do you have a preference? The other drivers are pretty old and 
> I don't have any hardware that would use them so I'd prefer to keep 
> them separate (though I'll acknowledge that they don't seem to have a 
> MAINTAINERS entry)
>
I should probably take a better look at the lenovo-hid driver.

The platforms that it's supporting weren't in the Linux program, so it never crossed my path before - but looking ahead I think we may need to contribute some changes there (guessing a little, but I'll know in a few months time).

Jiri - as that driver is targeted for Thinkpads, I'm OK to take some responsibility for it if that is useful/helpful.

Mark