linux-kernel - Re: [PATCH 2/2] ARM: dts: aspeed: Add Asus IPMI card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ13v3TqhKyT62NZFRz0dP0tov=q8fz99X_HgrJnwkd6Y5nEig@mail.gmail.com>
Date: Mon, 12 Jan 2026 15:16:47 -0600
From: Anirudh Srinivasan <anirudhsriniv@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>, 
	Andrew Jeffery <andrew@...econstruct.com.au>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: aspeed: Add Asus IPMI card

Hi Krzysztof,

On Mon, Jan 12, 2026 at 5:48 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> > +
> > +     leds {
> > +             compatible = "gpio-leds";
> > +
> > +             led-fault {
> > +                     gpios = <&gpio1 ASPEED_GPIO(C, 5) GPIO_ACTIVE_HIGH>;
> > +                     panic-indicator;
> > +                     default-state = "off";
>
> Missing color and function. Or at least label.

I will add this.

>
> > +             };
> > +
> > +             led-heartbeat {
> > +                     gpios = <&gpio0 ASPEED_GPIO(A, 7) GPIO_ACTIVE_LOW>;
> > +                     linux,default-trigger = "timer";
> > +             };
> > +
>
> Drop redundant blank lines.
>
> > +&mac2 {
> > +     status = "okay";
> > +
> > +     /* Bootloader sets up the MAC to insert delay */
> > +     phy-mode = "rgmii";
> > +     phy-handle = <&ethphy2>;
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_rgmii3_default>;
> > +};
> > +
> > +
>
> Like this as well. It's a sign of sloppy coding.

Will remove

>
> > +&fmc {
> > +     status = "okay";
> > +
> > +     flash@0 {
> > +             status = "okay";
> > +             m25p,fast-read;
> > +             label = "bmc";
> > +             spi-max-frequency = <50000000>;
> > +#include "openbmc-flash-layout-64.dtsi"
> > +     };
> > +};
>
> Best regards,
> Krzysztof
>

-- 
Regards
Anirudh Srinivasan