linux-kernel - Re: [PATCH 2/9] staging: rtl8723bs: remove empty branches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWSqrd0bOFBuxDtU@stanley.mountain>
Date: Mon, 12 Jan 2026 11:02:53 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Khushal Chitturi <khushalchitturi@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Michael Straube <straube.linux@...il.com>,
	Hans de Goede <hansg@...nel.org>, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/9] staging: rtl8723bs: remove empty branches

On Mon, Jan 12, 2026 at 12:06:23AM +0530, Khushal Chitturi wrote:
> Remove empty else blocks in rtw_xmit.c to improve
> readability and follow the kernel coding style.
> 
> Signed-off-by: Khushal Chitturi <khushalchitturi@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> index b0d7e59e492d..cf7d92a85d6c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> @@ -1707,8 +1707,6 @@ s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_frame *pxmitfram
>  		queue = &pxmitpriv->free_xmit_queue;
>  	else if (pxmitframe->ext_tag == 1)
>  		queue = &pxmitpriv->free_xframe_ext_queue;
> -	else {
> -	}
>  
>  	spin_lock_bh(&queue->lock);
>  
> @@ -1999,11 +1997,11 @@ inline bool xmitframe_hiq_filter(struct xmit_frame *xmitframe)
>  		)
>  			allow = true;
>  
> -	} else if (registry->hiq_filter == RTW_HIQ_FILTER_ALLOW_ALL)
> +	} else if (registry->hiq_filter == RTW_HIQ_FILTER_ALLOW_ALL) {
>  		allow = true;
> -	else if (registry->hiq_filter == RTW_HIQ_FILTER_DENY_ALL) {
> -	} else
> +	} else {
>  		rtw_warn_on(1);
> +	}

Please be more careful.  I'm not going to review the other patches.

regards,
dan carpenter