linux-kernel - Re: [PATCH 5/9] staging: rtl8723bs: split chained assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWSqS9fRMZXX8qsV@stanley.mountain>
Date: Mon, 12 Jan 2026 11:01:15 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Khushal Chitturi <khushalchitturi@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Michael Straube <straube.linux@...il.com>,
	Hans de Goede <hansg@...nel.org>, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/9] staging: rtl8723bs: split chained assignments

On Mon, Jan 12, 2026 at 12:06:26AM +0530, Khushal Chitturi wrote:
> @@ -1155,11 +1158,13 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, s
>  	u8 MME[_MME_IE_LENGTH_];
>  	u32 ori_len;
>  
> -	mem_start = pframe = (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET;
> +	mem_start = (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET;
> +	pframe = (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET;
>  	pwlanhdr = (struct ieee80211_hdr *)pframe;
>  
>  	ori_len = BIP_AAD_SIZE + pattrib->pktlen;
> -	tmp_buf = BIP_AAD = rtw_zmalloc(ori_len);
> +	tmp_buf = rtw_zmalloc(ori_len);
> +	BIP_AAD = rtw_zmalloc(ori_len);

Nope.  We don't want two allocations.

regards,
dan carpenter