linux-kernel - Re: [PATCH 3/9] staging: rtl8723bs: simplify boolean expressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWSub-JIUiEWUpv5@stanley.mountain>
Date: Mon, 12 Jan 2026 11:18:55 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Khushal Chitturi <khushalchitturi@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Michael Straube <straube.linux@...il.com>,
	Hans de Goede <hansg@...nel.org>, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/9] staging: rtl8723bs: simplify boolean expressions

On Mon, Jan 12, 2026 at 12:06:24AM +0530, Khushal Chitturi wrote:
>  	do_queue_select(padapter, &pxmitframe->attrib);
>  
>  	spin_lock_bh(&pxmitpriv->lock);
> -	if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe) == true) {
> +	if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe)) {
>  		spin_unlock_bh(&pxmitpriv->lock);
>  		return 1;
>  	}
>  	spin_unlock_bh(&pxmitpriv->lock);
>  
>  	/* pre_xmitframe */
> -	if (rtw_hal_xmit(padapter, pxmitframe) == false)
> +	if (rtw_hal_xmit(padapter, pxmitframe))

You reversed this if statement.  Really, just please throw this patchset
away and restart from scratch.  This wasn't my only complaint about this
patch but the other was more of a style issue and I think you will fix it
if you go slower.

>  		return 1;
>  
>  	return 0;

regards,
dan carpenter