| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <e1b69680-5d84-4ee3-bb0b-94578aa147ee@rock-chips.com>
Date: Mon, 12 Jan 2026 16:14:44 +0800
From: Joseph Chen <chenjh@...k-chips.com>
To: Diederik de Haas <diederik@...ow-tech.com>, lee@...nel.org,
lgirdwood@...il.com, broonie@...nel.org, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v1 1/2] dt-bindings: mfd: Add rk801 binding
在 2025/12/31 21:36, Diederik de Haas 写道:
> On Wed Dec 31, 2025 at 4:09 AM CET, Joseph Chen wrote:
>> Add DT binding document for Rockchip's RK801 PMIC
>>
>> Signed-off-by: Joseph Chen <chenjh@...k-chips.com>
>> ---
>> .../bindings/mfd/rockchip,rk801.yaml | 199 ++++++++++++++++++
>> 1 file changed, 199 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml
>> new file mode 100644
>> index 00000000000..d591125dfe8
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml
>> @@ -0,0 +1,199 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mfd/rockchip,rk801.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: RK801 Power Management Integrated Circuit
>> +
>> +maintainers:
>> + - Joseph Chen <chenjh@...k-chips.com>
>> +
>> +description: |
>> + Rockchip RK801 series PMIC. This device consists of an i2c controlled MFD
>> + that includes multiple switchable regulators.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - rockchip,rk801
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + rockchip,system-power-controller:
>> + type: boolean
>> + description:
>> + Telling whether or not this PMIC is controlling the system power.
>> +
>> + system-power-controller: true
> Why add 'rockchip,system-power-controller' while also adding
> 'system-power-controller'?
>
> Property 'rockchip,system-power-controller' was deprecated in commit
> 961748bb1555 ("dt-bindings: mfd: rk8xx: Deprecate rockchip,system-power-controller")
>
> And because of that I submitted this patch/commit:
> b99ac7e2a1cc ("arm64: dts: rockchip: Drop rockchip prefix of s-p-c PMIC prop from rk356x")
> to replace the deprecated variant with the non-deprecated one.
>
> Cheers,
> Diederik
Thanks for the review. I will drop this property in v2.
>> +
>> + wakeup-source:
>> + type: boolean
>> + description:
>> + Device can be used as a wakeup source.
>> +
>> + vcc1-supply:
>> + description:
>> + The input supply for DCDC_REG1.
>> +
>> + vcc2-supply:
>> + description:
>> + The input supply for DCDC_REG2.
>> +
>> + vcc3-supply:
>> + description:
>> + The input supply for DCDC_REG3.
>> +
>> + vcc4-supply:
>> + description:
>> + The input supply for DCDC_REG4.
>> +
>> + vcc5-supply:
>> + description:
>> + The input supply for LDO_REG1.
>> +
>> + vcc6-supply:
>> + description:
>> + The input supply for LDO_REG2.
>> +
>> + vcc7-supply:
>> + description:
>> + The input supply for SWITCH_REG.
>> +
>> + regulators:
>> + type: object
>> + patternProperties:
>> + "^(DCDC_REG[1-4]|LDO_REG[1-2]|SWITCH_REG)$":
>> + type: object
>> + $ref: /schemas/regulator/regulator.yaml#
>> + unevaluatedProperties: false
>> + unevaluatedProperties: false
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/pinctrl/rockchip.h>
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> + #include <dt-bindings/gpio/gpio.h>
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + rk801: rk801@27 {
>> + compatible = "rockchip,rk801";
>> + reg = <0x27>;
>> + interrupt-parent = <&gpio0>;
>> + interrupts = <RK_PC0 IRQ_TYPE_LEVEL_LOW>;
>> + pwrctrl-gpios = <&gpio0 RK_PC1 GPIO_ACTIVE_HIGH>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pmic_int_l>;
>> + rockchip,system-power-controller;
>> + wakeup-source;
>> +
>> + vcc1-supply = <&vcc12v_dcin>;
>> + vcc2-supply = <&vcc12v_dcin>;
>> + vcc3-supply = <&vcc5v0_sys>;
>> + vcc4-supply = <&vcc5v0_sys>;
>> + vcc5-supply = <&vcc3v3_sys>;
>> + vcc6-supply = <&vcc3v3_sys>;
>> + vcc7-supply = <&vcc3v3_sys>;
>> +
>> + regulators {
>> + vdd_cpu: DCDC_REG1 {
>> + regulator-name = "vdd_cpu";
>> + regulator-min-microvolt = <500000>;
>> + regulator-max-microvolt = <1500000>;
>> + regulator-initial-mode = <0x1>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + regulator-state-mem {
>> + regulator-mode = <0x2>;
>> + regulator-off-in-suspend;
>> + regulator-suspend-microvolt = <950000>;
>> + };
>> + };
>> +
>> + vcc3v3_sys: DCDC_REG2 {
>> + regulator-name = "vcc3v3_sys";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-initial-mode = <0x1>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + regulator-state-mem {
>> + regulator-mode = <0x2>;
>> + regulator-on-in-suspend;
>> + regulator-suspend-microvolt = <3300000>;
>> + };
>> + };
>> +
>> + vcc_ddr: DCDC_REG3 {
>> + regulator-name = "vcc_ddr";
>> + regulator-boot-on;
>> + regulator-always-on;
>> + regulator-state-mem {
>> + regulator-mode = <0x2>;
>> + regulator-on-in-suspend;
>> + };
>> + };
>> +
>> + vdd_logic: DCDC_REG4 {
>> + regulator-name = "vdd_logic";
>> + regulator-min-microvolt = <500000>;
>> + regulator-max-microvolt = <1500000>;
>> + regulator-initial-mode = <0x1>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + regulator-state-mem {
>> + regulator-mode = <0x2>;
>> + regulator-off-in-suspend;
>> + regulator-suspend-microvolt = <900000>;
>> + };
>> + };
>> +
>> + vdd0v9_sys: LDO_REG1 {
>> + regulator-name = "vdd0v9_sys";
>> + regulator-min-microvolt = <900000>;
>> + regulator-max-microvolt = <900000>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + regulator-state-mem {
>> + regulator-off-in-suspend;
>> + regulator-suspend-microvolt = <900000>;
>> + };
>> + };
>> +
>> + vcc_1v8: LDO_REG2 {
>> + regulator-name = "vcc_1v8";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <1800000>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + regulator-state-mem {
>> + regulator-off-in-suspend;
>> + regulator-suspend-microvolt = <1800000>;
>> + };
>> + };
>> +
>> + vcc_3v3: SWITCH_REG {
>> + regulator-name = "vcc_3v3";
>> + regulator-boot-on;
>> + regulator-always-on;
>> + regulator-state-mem {
>> + regulator-off-in-suspend;
>> + regulator-suspend-microvolt = <3300000>;
>> + };
>> + };
>> + };
>> + };
>> + };
>
>
--
Best regards,
Joseph Chen
Powered by blists - more mailing lists