linux-kernel - Re: [PATCH v1 1/2] dt-bindings: mfd: Add rk801 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <143cd9e0-5920-4cce-b544-184aa62373a5@rock-chips.com>
Date: Mon, 12 Jan 2026 16:26:07 +0800
From: Joseph Chen <chenjh@...k-chips.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, lee@...nel.org,
 lgirdwood@...il.com, broonie@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v1 1/2] dt-bindings: mfd: Add rk801 binding


在 2025/12/31 15:33, Krzysztof Kozlowski 写道:
> On 31/12/2025 04:09, Joseph Chen wrote:
>> Add DT binding document for Rockchip's RK801 PMIC
>>
>> Signed-off-by: Joseph Chen <chenjh@...k-chips.com>
>> ---
>
> 1. Please use scripts/get_maintainers.pl to get a list of necessary
> people and lists to CC. It might happen, that command when run on an
> older kernel, gives you outdated entries. Therefore please be sure you
> base your patches on recent Linux kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
>
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.
>
> Please kindly resend and include all necessary To/Cc entries.
>
>
> 2. Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> If you cannot find a name matching your device, please check in kernel
> sources for similar cases or you can grow the spec (via pull request to
> DT spec repo).
>
> 3. Underscore is not allowed in node names. Neither capital letters.
> Please read DTS coding style.
>
> Best regards,
> Krzysztof
>
Thanks for the review and advice . I will fix all these problems in v2.

-- 
Best regards,
Joseph Chen