linux-kernel - [PATCH 1/2] dt-bindings: usb: parade,ps5511: Disallow unevaluated properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260112090149.69100-3-krzysztof.kozlowski@oss.qualcomm.com>
Date: Mon, 12 Jan 2026 10:01:50 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Pin-yen Lin <treapking@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>,
        stable@...r.kernel.org
Subject: [PATCH 1/2] dt-bindings: usb: parade,ps5511: Disallow unevaluated properties

Review given to v2 [1] of commit fc259b024cb3 ("dt-bindings: usb: Add
binding for PS5511 hub controller") asked to use unevaluatedProperties,
but this was ignored by the author probably because current dtschema
does not allow to use both additionalProperties and
unevaluatedProperties.  As an effect, this binding does not end with
unevaluatedProperties and allows any properties to be added.

Fix this by reverting the approach suggested at v2 review and using
simpler definition of "reg" constraints.

Link: https://lore.kernel.org/r/20250416180023.GB3327258-robh@kernel.org/ [1]
Fixes: fc259b024cb3 ("dt-bindings: usb: Add binding for PS5511 hub controller")
Cc: <stable@...r.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
---
 .../devicetree/bindings/usb/parade,ps5511.yaml       | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/parade,ps5511.yaml b/Documentation/devicetree/bindings/usb/parade,ps5511.yaml
index 10d002f09db8..154d779e507a 100644
--- a/Documentation/devicetree/bindings/usb/parade,ps5511.yaml
+++ b/Documentation/devicetree/bindings/usb/parade,ps5511.yaml
@@ -15,6 +15,10 @@ properties:
       - usb1da0,5511
       - usb1da0,55a1
 
+  reg:
+    minimum: 1
+    maximum: 5
+
   reset-gpios:
     items:
       - description: GPIO specifier for RESETB pin.
@@ -41,12 +45,6 @@ properties:
             minimum: 1
             maximum: 5
 
-additionalProperties:
-  properties:
-    reg:
-      minimum: 1
-      maximum: 5
-
 required:
   - peer-hub
 
@@ -67,6 +65,8 @@ allOf:
       patternProperties:
         '^.*@5$': false
 
+unevaluatedProperties: false
+
 examples:
   - |
     usb {
-- 
2.51.0