linux-kernel - [PATCH 2/2] dt-bindings: usb: realtek,rts5411: Disallow unevaluated properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260112090149.69100-4-krzysztof.kozlowski@oss.qualcomm.com>
Date: Mon, 12 Jan 2026 10:01:51 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Pin-yen Lin <treapking@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>,
        stable@...r.kernel.org
Subject: [PATCH 2/2] dt-bindings: usb: realtek,rts5411: Disallow unevaluated properties

Review given to v2 [1] of commit 76cbb3eabf0b ("dt-bindings: usb:
realtek,rts5411: Adapt usb-hub.yaml") asked to use
unevaluatedProperties, but this was ignored by the author probably
because current dtschema does not allow to use both additionalProperties
and unevaluatedProperties.  As an effect, this binding does not end with
unevaluatedProperties and allows any properties to be added.

Fix this by reverting the approach suggested at v2 review and using
simpler definition of "reg" constraints.

Link: https://lore.kernel.org/r/20250416180023.GB3327258-robh@kernel.org/ [1]
Fixes: 76cbb3eabf0b ("dt-bindings: usb: realtek,rts5411: Adapt usb-hub.yaml")
Cc: <stable@...r.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
---
 .../devicetree/bindings/usb/realtek,rts5411.yaml     | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml b/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml
index a020afaf2d6e..a86afa8fdc91 100644
--- a/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml
+++ b/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml
@@ -19,6 +19,10 @@ properties:
           - usbbda,5411
           - usbbda,411
 
+  reg:
+    minimum: 1
+    maximum: 4
+
   vdd-supply:
     description:
       phandle to the regulator that provides power to the hub.
@@ -37,17 +41,13 @@ properties:
             minimum: 1
             maximum: 4
 
-additionalProperties:
-  properties:
-    reg:
-      minimum: 1
-      maximum: 4
-
 required:
   - peer-hub
   - compatible
   - reg
 
+unevaluatedProperties: false
+
 examples:
   - |
     usb {
-- 
2.51.0