linux-kernel - Re: [PATCH v3 2/3] ACPI: APEI: GHES: Extract helper functions for error status handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7yvemd3p7vxqxey5fcd45gth5dnplkgyoupkfji5pt5p4dfuvi@ult7tm6sys36>
Date: Mon, 12 Jan 2026 01:39:56 -0800
From: Breno Leitao <leitao@...ian.org>
To: Shuai Xue <xueshuai@...ux.alibaba.com>
Cc: tony.luck@...el.com, guohanjun@...wei.com, mchehab@...nel.org, 
	dolinux.peng@...il.com, yazen.ghannam@....com, rafael@...nel.org, dave.jiang@...el.com, 
	Smita.KoralahalliChannabasappa@....com, pengdonglin@...omi.com, baolin.wang@...ux.alibaba.com, 
	benjamin.cheatham@....com, bp@...en8.de, dan.j.williams@...el.com, james.morse@....com, 
	lenb@...nel.org, linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, 
	zhuo.song@...ux.alibaba.com
Subject: Re: [PATCH v3 2/3] ACPI: APEI: GHES: Extract helper functions for
 error status handling

On Mon, Jan 12, 2026 at 11:22:38AM +0800, Shuai Xue wrote:
> Refactors the GHES driver by extracting common functionality into
> reusable helper functions:
> 
> 1. ghes_has_active_errors() - Checks if any error sources in a given list
>    have active errors
> 2. ghes_map_error_status() - Maps error status address to virtual address
> 3. ghes_unmap_error_status() - Unmaps error status virtual address
> 4. Use `guard(rcu)()` instead of explicit `rcu_read_lock()`/`rcu_read_unlock()`.
> 
> These helpers eliminate code duplication in the NMI path and prepare for
> similar usage in the SEA path in a subsequent patch.
> 
> No functional change intended.
> 
> Tested-by: Tony Luck <tony.luck@...el.com>
> Reviewed-by: Tony Luck <tony.luck@...el.com>
> Signed-off-by: Shuai Xue <xueshuai@...ux.alibaba.com>

Reviewed-by: Breno Leitao <leitao@...ian.org>