linux-kernel - Re: [PATCH 2/2] ARM: dts: aspeed: Add Asus IPMI card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ13v3TmUQ8oQT6uwK_=rP7vWXy37Gzjmgv=cg_3HkgerPJNFA@mail.gmail.com>
Date: Sun, 11 Jan 2026 20:35:47 -0600
From: Anirudh Srinivasan <anirudhsriniv@...il.com>
To: Andrew Jeffery <andrew@...econstruct.com.au>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: aspeed: Add Asus IPMI card

Hi Andrew,

On Sun, Jan 11, 2026 at 7:47 PM Andrew Jeffery
<andrew@...econstruct.com.au> wrote:
>
> > +/ {
> > +     model = "ASUS IPMI Card BMC";
>
> I'd drop the "BMC" from the model description as well (wrt the
> discussion on patch 1/2).

Yes, I realized sticking to its official name everywhere might just
make better sense.

I'll make this name "ASUS IPMI Expansion Card", change the compatible
to "asus,ipmi-expansion-card" and the dtb name to
"aspeed-bmc-asus-ipmi-expansion-card.dtb".

>
> This looks good in general.
>
> For the purpose of review I've started requesting that phandle
> references be ordered alphabetically, because it's tedious to confirm
> they're ordered by unit address, and it's nice to have consistency
> across the files. Can you please fix that along with Andrew Lunn's
> concern about the phy-mode?

Will fix this up and resend another series. Thanks for your quick response.

--
Regards
Anirudh Srinivasan