linux-kernel - Re: [PATCH 1/2] dt-bindings: arm: aspeed: Add Asus IPMI card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260112-whimsical-annoying-fulmar-25e4d9@quoll>
Date: Mon, 12 Jan 2026 12:47:16 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andrew Jeffery <andrew@...econstruct.com.au>
Cc: Anirudh Srinivasan <anirudhsriniv@...il.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: Add Asus IPMI card

On Mon, Jan 12, 2026 at 12:01:27PM +1030, Andrew Jeffery wrote:
> On Sun, 2026-01-11 at 14:10 -0600, Anirudh Srinivasan wrote:
> > Document the new comptaibles for Asus IPMI card
> > 
> > Signed-off-by: Anirudh Srinivasan <anirudhsriniv@...il.com>
> > ---
> >  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> > index 9298c1a75dd1..b2d20341f8eb 100644
> > --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> > +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> > @@ -79,6 +79,7 @@ properties:
> >                - ampere,mtmitchell-bmc
> >                - aspeed,ast2600-evb
> >                - aspeed,ast2600-evb-a1
> > +              - asus,ipmi-card-bmc
> 
> It's a bit bike-sheddy, however: the pattern tends to be
> ${vendor},${platform}-bmc, but as the platform can't be specified and
> the card's function is the BMC itself, I'd go with "asus,ipmi-
> expansion-card" (I couldn't immediately find a useful identifier other
> than the product name).

This should include some model name or at least soc. What if you have
IPMI card for ast2600 and later completely different for ast2700?

Best regards,
Krzysztof