lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20260113215603.GA781891@bhelgaas>
Date: Tue, 13 Jan 2026 15:56:03 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: huyuye <huyuye812@....com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>,
	"Rafael J . Wysocki" <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>, Sunil V L <sunilvl@...tanamicro.com>,
	Paul Walmsley <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
	Robert Moore <robert.moore@...el.com>, linux-pci@...r.kernel.org,
	linux-acpi@...r.kernel.org, linux-riscv@...ts.infradead.org,
	acpica-devel@...ts.linux.dev, linux-kernel@...r.kernel.org,
	dai.hualiang@....com.cn, deng.weixian@....com.cn,
	guo.chang2@....com.cn, liu.qingtao2@....com.cn,
	wu.jiabao@....com.cn, lin.yongchun@....com.cn, hu.yuye@....com.cn,
	zhang.longxiang@....com.cn, zuo.jiang@....com.cn,
	li.kunpeng@....com.cn
Subject: Re: [PATCH v2] ACPI: pci_root: Clear the acpi dependencies after PCI
 root bridge initialization on RISC-V

On Mon, Jan 12, 2026 at 10:16:29PM +0800, huyuye wrote:
> Hi Rafael,
> Thank you for your thorough review and valuable comments on v1.
> I've updated the patch as follows:
> 1. Removed the redundant #ifdef CONFIG_ACPI and if (!acpi_disabled) 
> guard as you pointed out. The entire code block indeed already depends
> on CONFIG_ACPI at a higher level, making the inner guard unnecessary.
> 2. Moved acpi_dev_clear_dependencies to RISC-V specific architecture 
> code (driver/acpi/riscv/acpi_pci.c). This ensures that ACPI dependency
> clearing is handled within the appropriate architectural context.
> 
> Best regards

This really should have the commit log here, as it did in the original
post [1].

> Signed-off-by: huyuye <huyuye812@....com> 
> ---

And the description of the changes from v1 to v2 can go here, after
the "---" since it doesn't need to be part of the permanent git
history; see [2].

[1] https://lore.kernel.org/r/20251203140716.3065-1-huyuye812@163.com
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.18#n784

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ