linux-kernel - Re: [PATCH v2 ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: remove obsolete firmware-name property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa997674-402a-41cf-9334-f7fc89ae5ebc@kernel.org>
Date: Tue, 13 Jan 2026 08:28:43 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Miaoqing Pan <miaoqing.pan@....qualcomm.com>, jjohnson@...nel.org,
 johannes@...solutions.net, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org
Cc: ath11k@...ts.infradead.org, linux-wireless@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 ath-current 2/2] dt-bindings: net: wireless:
 ath11k-pci: remove obsolete firmware-name property

On 14/12/2025 03:52, Miaoqing Pan wrote:
> The firmware-name property was introduced to allow end-users and
> integrators to select usecase specific firmware for the WCN6855.
> However, specifying firmware for an M.2 WLAN module in the Device
> Tree is not appropriate. Instead, this functionality will be handled
> within the ath11k driver.
> 
> The driver has removed all support for firmware-name, and no upstream
> Device Tree files reference this property. Therefore, this patch
> removes the property from the binding and marks it as obsolete.

No, it does not mark it obsolete. Point me to the place.

> 
> This is a DT ABI-breaking change, but safe since there are no in-tree
> users.

It's not safe. What about my board using this WiFi? Or Mr. foo's board?

Still NAK, you did not improve it.


> 
> Acked-by: Rob Herring (Arm) <robh@...nel.org>

And that's a fake tag.

Rob never acked such patch! Adding tags for something completely
different is not acceptable.


Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

> Signed-off-by: Miaoqing Pan <miaoqing.pan@....qualcomm.com>
> ---
>  .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml   | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
> index e34d42a30192..653b319fee88 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
> @@ -35,12 +35,6 @@ properties:
>        string to uniquely identify variant of the calibration data for designs
>        with colliding bus and device ids
>  
> -  firmware-name:
> -    maxItems: 1
> -    description:
> -      If present, a board or platform specific string used to lookup
> -      usecase-specific firmware files for the device.
> -
>    vddrfacmn-supply:
>      description: VDD_RFA_CMN supply regulator handle
>  


Best regards,
Krzysztof