linux-kernel - Re: [PATCH v2 ath-current 1/2] wifi: ath11k: add usecase firmware handling based on device compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12234020-267c-4d62-baff-89e6d053f24e@kernel.org>
Date: Tue, 13 Jan 2026 08:30:31 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Miaoqing Pan <miaoqing.pan@....qualcomm.com>, jjohnson@...nel.org,
 johannes@...solutions.net, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org
Cc: ath11k@...ts.infradead.org, linux-wireless@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 Baochen Qiang <baochen.qiang@....qualcomm.com>
Subject: Re: [PATCH v2 ath-current 1/2] wifi: ath11k: add usecase firmware
 handling based on device compatible

On 14/12/2025 03:52, Miaoqing Pan wrote:
> For M.2 WLAN chips, there is no suitable DTS node to specify the
> firmware-name property. In addition, assigning firmware for the
> M.2 PCIe interface causes chips that do not use usecase specific
> firmware to fail. Therefore, abandoning the approach of specifying
> firmware in DTS. As an alternative, propose a static lookup table
> mapping device compatible to firmware names. Currently, only WCN6855
> HW2.1 requires this.
> 
> For details on usecase specific firmware, see:
> https://lore.kernel.org/all/20250522013444.1301330-3-miaoqing.pan@oss.qualcomm.com/.
> 
> Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-04685-QCAHSPSWPL_V1_V2_SILICONZ_IOE-1
> 
> Fixes: edbbc647c4f3 ("wifi: ath11k: support usercase-specific firmware overrides")
> Reviewed-by: Baochen Qiang <baochen.qiang@....qualcomm.com>
> Signed-off-by: Miaoqing Pan <miaoqing.pan@....qualcomm.com>
> ---

I already said why it is wrong patch and you did not improve. You also
added tags from reviews of something completely different, which
effectively bypassed my filters. I find it unacceptable.

Let me mark it formally:

NAK

Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

Best regards,
Krzysztof