linux-kernel - [PATCH v2 3/4] usb: gadget: uvc: return error from uvcg_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260113-uvc-gadget-fix-patch-v2-3-62950ef5bcb5@nxp.com>
Date: Tue, 13 Jan 2026 17:53:09 +0800
From: Xu Yang <xu.yang_2@....com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Michael Grzeschik <m.grzeschik@...gutronix.de>
Cc: jun.li@....com, imx@...ts.linux.dev, linux-usb@...r.kernel.org, 
 linux-kernel@...r.kernel.org, Xu Yang <xu.yang_2@....com>
Subject: [PATCH v2 3/4] usb: gadget: uvc: return error from
 uvcg_queue_init()

uvcg_queue_init() may fail, but its return value is currently ignored.
Propagate the error code from uvcg_queue_init() to correctly report
initialization failures.

Signed-off-by: Xu Yang <xu.yang_2@....com>

---
Changes in v2:
 - improve commit message
---
 drivers/usb/gadget/function/uvc_video.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/function/uvc_video.c b/drivers/usb/gadget/function/uvc_video.c
index 9dc3af16e2f38957198bf579987f4324fc552c5d..f568dee08b3b7273be124a673682c02d20f7c77b 100644
--- a/drivers/usb/gadget/function/uvc_video.c
+++ b/drivers/usb/gadget/function/uvc_video.c
@@ -838,7 +838,6 @@ int uvcg_video_init(struct uvc_video *video, struct uvc_device *uvc)
 	video->interval = 666666;
 
 	/* Initialize the video buffers queue. */
-	uvcg_queue_init(&video->queue, uvc->v4l2_dev.dev->parent,
+	return uvcg_queue_init(&video->queue, uvc->v4l2_dev.dev->parent,
 			V4L2_BUF_TYPE_VIDEO_OUTPUT, &video->mutex);
-	return 0;
 }

-- 
2.34.1